drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aman Sinha" <asi...@maprtech.com>
Subject Re: Review Request 32886: DRILL-2639: Planner bug - RelOptPlanner.CannotPlanExceptio
Date Fri, 10 Apr 2015 03:30:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32886/#review79631
-----------------------------------------------------------



exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java
<https://reviews.apache.org/r/32886/#comment129131>

    Pls use SqlTypeName.getName() instead of toString() even though getName() returns the
toString value.


- Aman Sinha


On April 10, 2015, 12:52 a.m., Sean Hsuan-Yi Chu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32886/
> -----------------------------------------------------------
> 
> (Updated April 10, 2015, 12:52 a.m.)
> 
> 
> Review request for drill and Aman Sinha.
> 
> 
> Bugs: DRILL-2639
>     https://issues.apache.org/jira/browse/DRILL-2639
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> At planning for Union-All, block only the cases where implicit casting cannot resolve
an output type
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/drill/common/types/Types.java 015ee90 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java
aba6022 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillUnionRelBase.java
932aa76 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillOptiq.java
796f0f7 
>   exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java 7033013 
> 
> Diff: https://reviews.apache.org/r/32886/diff/
> 
> 
> Testing
> -------
> 
> QA, unit
> 
> 
> Thanks,
> 
> Sean Hsuan-Yi Chu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message