drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hanifi Gunes" <hanifigu...@gmail.com>
Subject Re: Review Request 33030: DRILL-2685: Unique-ify local Hive metastore directory per test JVM
Date Fri, 10 Apr 2015 01:02:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33030/#review79609
-----------------------------------------------------------


close to shipping.


contrib/storage-hive/core/src/test/java/org/apache/drill/exec/store/hive/HiveTestDataGenerator.java
<https://reviews.apache.org/r/33030/#comment129107>

    We should avoid heavy initialization in c'tor. We can delegate functionality to a init
method and call it in getInst.


- Hanifi Gunes


On April 10, 2015, 12:22 a.m., Venki Korukanti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33030/
> -----------------------------------------------------------
> 
> (Updated April 10, 2015, 12:22 a.m.)
> 
> 
> Review request for drill, Hanifi Gunes and Mehant Baid.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Please see DRILL-2685 for details.
> 
> 
> Diffs
> -----
> 
>   contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/HiveTestBase.java
1c7e16d 
>   contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/TestHiveStorage.java
a76128f 
>   contrib/storage-hive/core/src/test/java/org/apache/drill/exec/sql/hive/TestViewSupportOnHiveTables.java
14ab506 
>   contrib/storage-hive/core/src/test/java/org/apache/drill/exec/store/hive/HiveTestDataGenerator.java
657da61 
> 
> Diff: https://reviews.apache.org/r/33030/diff/
> 
> 
> Testing
> -------
> 
> Ran concurrent tests by setting forkCount > 1
> 
> 
> Thanks,
> 
> Venki Korukanti
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message