drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hanifi Gunes" <hanifigu...@gmail.com>
Subject Re: Review Request 33030: DRILL-2685: Unique-ify local Hive metastore directory per test JVM
Date Thu, 09 Apr 2015 22:32:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33030/#review79581
-----------------------------------------------------------


initial set of comments


contrib/storage-hive/core/src/test/java/org/apache/drill/exec/store/hive/HiveTestDataGenerator.java
<https://reviews.apache.org/r/33030/#comment129058>

    We should make this class a singleton instead of declaring variables static.



contrib/storage-hive/core/src/test/java/org/apache/drill/exec/store/hive/HiveTestDataGenerator.java
<https://reviews.apache.org/r/33030/#comment129059>

    This logic should be moved into factory method after singleton refactoring.



contrib/storage-hive/core/src/test/java/org/apache/drill/exec/store/hive/HiveTestDataGenerator.java
<https://reviews.apache.org/r/33030/#comment129060>

    unneeded after singleton refac (I think)



contrib/storage-hive/core/src/test/java/org/apache/drill/exec/store/hive/HiveTestDataGenerator.java
<https://reviews.apache.org/r/33030/#comment129045>

    Use java.nio.Files.createTempFile instead of this method.



contrib/storage-hive/core/src/test/java/org/apache/drill/exec/store/hive/HiveTestDataGenerator.java
<https://reviews.apache.org/r/33030/#comment129063>

    let's not mark these methods static as the class will be singleton and we will have one
& only one instance either way. Else, I would recommend moving all sub-related convenience
methods to a utility class for keeping class members cohesive.


- Hanifi Gunes


On April 9, 2015, 7:16 p.m., Venki Korukanti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33030/
> -----------------------------------------------------------
> 
> (Updated April 9, 2015, 7:16 p.m.)
> 
> 
> Review request for drill, Hanifi Gunes and Mehant Baid.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Please see DRILL-2685 for details.
> 
> 
> Diffs
> -----
> 
>   contrib/storage-hive/core/src/test/java/org/apache/drill/exec/store/hive/HiveTestDataGenerator.java
657da61 
> 
> Diff: https://reviews.apache.org/r/33030/diff/
> 
> 
> Testing
> -------
> 
> Ran concurrent tests by setting forkCount > 1
> 
> 
> Thanks,
> 
> Venki Korukanti
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message