drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steven Phillips" <sphill...@maprtech.com>
Subject Review Request 32949: DRILL-2718: Handle counting and status of sent batches by FragmentContext
Date Wed, 08 Apr 2015 00:57:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32949/
-----------------------------------------------------------

Review request for drill, Chris Westin and Jacques Nadeau.


Repository: drill-git


Description
-------

Creates wrapper classes FragmentDataTunnel and FragmentUserDataTunnel which wrap
the DataTunnel and UserClientConnection, respectively, allowing us to use DataTunnels
and UserClientConnections from a global pool, but track pending batches and send status
at the FragmentContext level.

Consolidates the various StatusListener implementations used by the various senders and
instead uses just one implementation.


Diffs
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java 18b93e9 
  exec/java-exec/src/main/java/org/apache/drill/exec/ops/SendingAccountor.java PRE-CREATION

  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/BaseRootExec.java a00df9d

  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScreenCreator.java 8038527

  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/SendingAccountor.java 21fc800

  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/SingleSenderCreator.java
1ef7bbd 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/broadcastsender/BroadcastSenderRootExec.java
d17fdd4 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/PartitionSenderRootExec.java
6a73cdd 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/Partitioner.java
9d6e98f 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/PartitionerTemplate.java
33d6f95 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/StatusHandler.java
5e21878 
  exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserClient.java 8022c95 

Diff: https://reviews.apache.org/r/32949/diff/


Testing
-------

No new functionality, so no new tests. Current tests all pass.


Thanks,

Steven Phillips


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message