drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Barclay" <dbarc...@maprtech.com>
Subject Review Request 32801: DRILL-2668: Fix: CAST(1.1 AS FLOAT) was yielding DOUBLE.
Date Tue, 07 Apr 2015 05:21:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32801/
-----------------------------------------------------------

Review request for drill, Mehant Baid and Parth Chandra.


Bugs: DRILL-2668
    https://issues.apache.org/jira/browse/DRILL-2668


Repository: drill-git


Description
-------

Added test method (and others for parallel cases) to TestFunctionsQuery.
Fixed use of DOUBLE methods/classes for FLOAT:
- Changed a FLOAT -> DOUBLE mapping in ValueExpressions.
- Added parallel FLOAT methods/classes in EvaluationVisitor.


Diffs
-----

  common/src/main/java/org/apache/drill/common/expression/ValueExpressions.java e095e7e 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/EvaluationVisitor.java 386ab79 
  exec/java-exec/src/test/java/org/apache/drill/TestFunctionsQuery.java f1005ab 

Diff: https://reviews.apache.org/r/32801/diff/


Testing
-------

Ran new specific test and existing tests.


Thanks,

Daniel Barclay


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message