drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Parth Chandra" <pchan...@maprtech.com>
Subject Re: Review Request 32800: C++ Client Authentication API passing std::string across DLL boundaries
Date Tue, 07 Apr 2015 02:32:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32800/#review79116
-----------------------------------------------------------

Ship it!


Ship It!

- Parth Chandra


On April 6, 2015, 6:30 p.m., Norris Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32800/
> -----------------------------------------------------------
> 
> (Updated April 6, 2015, 6:30 p.m.)
> 
> 
> Review request for drill, Alexander zarei, Parth Chandra, and Xiao Meng.
> 
> 
> Bugs: DRILL-2671
>     https://issues.apache.org/jira/browse/DRILL-2671
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> DrillUserProperty::setProperty is taking std::string as parameters. Memory gets allocated
in the client yet Drill Client tries to clean it up.
> 
> 
> Diffs
> -----
> 
>   contrib/native/client/src/include/drill/drillClient.hpp 9289df3 
> 
> Diff: https://reviews.apache.org/r/32800/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Norris Lee
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message