drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Venki Korukanti" <venki.koruka...@gmail.com>
Subject Re: Review Request 32849: DRILL-2672: C++ Client - Update for authentication changes
Date Sat, 04 Apr 2015 04:58:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32849/#review78877
-----------------------------------------------------------


LGTM. I have couple of qns.


contrib/native/client/src/clientlib/drillClientImpl.cpp
<https://reviews.apache.org/r/32849/#comment127962>

    It seems like we are not getting any RPC version from server as it broke off the connection.
Do we want to change the error message here?



contrib/native/client/src/clientlib/drillClientImpl.cpp
<https://reviews.apache.org/r/32849/#comment127960>

    Do we still need this?


- Venki Korukanti


On April 4, 2015, 2:43 a.m., Parth Chandra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32849/
> -----------------------------------------------------------
> 
> (Updated April 4, 2015, 2:43 a.m.)
> 
> 
> Review request for drill, Alexander zarei, Norris Lee, Venki Korukanti, and Xiao Meng.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> C++ Client - Update for authentication changes
> 
> 
> Diffs
> -----
> 
>   contrib/native/client/src/clientlib/drillClient.cpp 90aa555 
>   contrib/native/client/src/clientlib/drillClientImpl.hpp 95fe922 
>   contrib/native/client/src/clientlib/drillClientImpl.cpp dce5bdc 
>   contrib/native/client/src/clientlib/errmsgs.hpp 22e544f 
>   contrib/native/client/src/clientlib/errmsgs.cpp fa72721 
>   contrib/native/client/src/include/drill/common.hpp 72b9a98 
>   contrib/native/client/src/protobuf/User.pb.h 69daf50 
>   contrib/native/client/src/protobuf/User.pb.cc 360becb 
> 
> Diff: https://reviews.apache.org/r/32849/diff/
> 
> 
> Testing
> -------
> 
> Ran Manual tests to check authentication works with valid/invalid username and password
combinations
> 
> 
> Thanks,
> 
> Parth Chandra
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message