drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Hsuan-Yi Chu" <hsua...@usc.edu>
Subject Re: Review Request 32590: DRILL-2591: In UnionAllRecordBactch, the mechansim to detect schema change is corrected
Date Sat, 04 Apr 2015 03:07:13 GMT


> On April 3, 2015, 12:15 a.m., Aman Sinha wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java,
line 123
> > <https://reviews.apache.org/r/32590/diff/2/?file=912235#file912235line123>
> >
> >     It's not clear to me why we have to check specifically for NumberFormatException
here...this is just another type of IllegalArgumentException.

This one is for issue DRILL-2608. 

This will give the user proper error message regarding implicit casting failure.

Would it be better to make it be another new patch ???


> On April 3, 2015, 12:15 a.m., Aman Sinha wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java,
line 334
> > <https://reviews.apache.org/r/32590/diff/2/?file=912235#file912235line334>
> >
> >     For schema equivalence why do we need a new method ? Did you try equals() ?
 Having a separate method can be prone to bugs later if it gets out of sync with attributes
of the class.

Done!


- Sean Hsuan-Yi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32590/#review78745
-----------------------------------------------------------


On April 3, 2015, 8:04 p.m., Sean Hsuan-Yi Chu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32590/
> -----------------------------------------------------------
> 
> (Updated April 3, 2015, 8:04 p.m.)
> 
> 
> Review request for drill and Aman Sinha.
> 
> 
> Bugs: DRILL-2591.1
>     https://issues.apache.org/jira/browse/DRILL-2591.1
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> DRILL-2591: In UnionAllRecordBactch, the mechansim to detect schema change is corrected
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
806104a 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/FinalColumnReorderer.java
1aa033b 
>   exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java fcf5c9f 
>   exec/java-exec/src/test/resources/store/json/dateData.json PRE-CREATION 
>   exec/java-exec/src/test/resources/store/json/timeStmpData.json PRE-CREATION 
>   exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q18.tsv PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/32590/diff/
> 
> 
> Testing
> -------
> 
> QA, unit all passed
> 
> 
> Thanks,
> 
> Sean Hsuan-Yi Chu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message