drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Venki Korukanti" <venki.koruka...@gmail.com>
Subject Re: Review Request 32831: DRILL-2674: Add user authenticator interface and PAM based implementation
Date Sat, 04 Apr 2015 01:18:28 GMT


> On April 4, 2015, 12:49 a.m., Parth Chandra wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java, line
201
> > <https://reviews.apache.org/r/32831/diff/2/?file=914900#file914900line201>
> >
> >     Initialize this to empty string? If the client does not pass a password you
wont pass a NULL to the authenticator.

Make sense. Will update it in next patch.


- Venki


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32831/#review78872
-----------------------------------------------------------


On April 3, 2015, 9:10 p.m., Venki Korukanti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32831/
> -----------------------------------------------------------
> 
> (Updated April 3, 2015, 9:10 p.m.)
> 
> 
> Review request for drill, Jacques Nadeau and Parth Chandra.
> 
> 
> Bugs: DRILL-2674
>     https://issues.apache.org/jira/browse/DRILL-2674
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> See DRILL-2674 and comment section of new interfaces added.
> 
> Currently native component of libjpam.so is not packaged with the tar.gz file. It needs
to be manually copied. Will be addressing that in a separate jira, once I figure out the location
from where it can be pulled as part of the build.
> 
> 
> Diffs
> -----
> 
>   distribution/src/resources/drill-override-example.conf 4cd342a 
>   exec/java-exec/pom.xml dfb1a6b 
>   exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java 14e6ad1 
>   exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java c76d324

>   exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java efb0cdf

>   exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/security/PamUserAuthenticator.java
PRE-CREATION 
>   exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/security/UserAuthenticationException.java
PRE-CREATION 
>   exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/security/UserAuthenticator.java
PRE-CREATION 
>   exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/security/UserAuthenticatorFactory.java
PRE-CREATION 
>   exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/security/UserAuthenticatorTemplate.java
PRE-CREATION 
>   exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java 2efc9a9

>   exec/java-exec/src/main/resources/drill-module.conf af225c4 
>   exec/java-exec/src/test/java/org/apache/drill/BaseTestQuery.java 64cf2ec 
>   exec/java-exec/src/test/java/org/apache/drill/QueryTestUtil.java 3d19229 
>   exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestLocalExchange.java
08655e3 
>   exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/partitionsender/TestPartitionSender.java
bdb020b 
>   exec/java-exec/src/test/java/org/apache/drill/exec/rpc/user/security/TestCustomUserAuthenticator.java
PRE-CREATION 
>   exec/java-exec/src/test/java/org/apache/drill/exec/rpc/user/security/UserAuthenticatorTestImpl.java
PRE-CREATION 
>   exec/java-exec/src/test/java/org/apache/drill/exec/server/TestDrillbitResilience.java
9bc0552 
>   pom.xml 8c9f09e 
> 
> Diff: https://reviews.apache.org/r/32831/diff/
> 
> 
> Testing
> -------
> 
> Added tests which use a test implementation of UserAuthenticator. These also test DRILL-2673.
For PAM, manually tested on Linux machine. No unittests for PAM as they depend on specific
users and their credentials on the machine where unittests are run. Will be working with QA
to add a functional test in regression suite.
> 
> 
> Thanks,
> 
> Venki Korukanti
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message