drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Venki Korukanti" <venki.koruka...@gmail.com>
Subject Re: Review Request 32819: DRILL-2673 Update UserServer <==> UserClient RPC to handle handshake response better
Date Sat, 04 Apr 2015 01:00:29 GMT


> On April 4, 2015, 12:03 a.m., Parth Chandra wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserClient.java, line
118
> > <https://reviews.apache.org/r/32819/diff/3/?file=914887#file914887line118>
> >
> >     Is this block redundant now? Status will not be success if the RPC version does
not match.

Yeah, this code is redundant. Will remove it in next patch.


- Venki


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32819/#review78865
-----------------------------------------------------------


On April 3, 2015, 8:29 p.m., Venki Korukanti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32819/
> -----------------------------------------------------------
> 
> (Updated April 3, 2015, 8:29 p.m.)
> 
> 
> Review request for drill, Jacques Nadeau and Parth Chandra.
> 
> 
> Bugs: DRILL-2673
>     https://issues.apache.org/jira/browse/DRILL-2673
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Please see DRILL-2673 for details
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java 6d4c86c

>   exec/java-exec/src/main/java/org/apache/drill/exec/rpc/AbstractHandshakeHandler.java
9048241 
>   exec/java-exec/src/main/java/org/apache/drill/exec/rpc/BasicServer.java 0e0398d 
>   exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserClient.java 925154d

>   exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserRpcConfig.java 908d304

>   exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java c76d324

>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java e590778 
>   protocol/src/main/java/org/apache/drill/exec/proto/SchemaUserProtos.java 3b056cf 
>   protocol/src/main/java/org/apache/drill/exec/proto/UserProtos.java 048bd20 
>   protocol/src/main/java/org/apache/drill/exec/proto/beans/BitToUserHandshake.java 813eb1c

>   protocol/src/main/java/org/apache/drill/exec/proto/beans/HandshakeStatus.java PRE-CREATION

>   protocol/src/main/protobuf/User.proto 6c41a37 
> 
> Diff: https://reviews.apache.org/r/32819/diff/
> 
> 
> Testing
> -------
> 
> Existing unittests pass. Negative tests which involve handshake request result in error
are not available in this patch, because the only case where we could introduce the failure
is when the RPC version mismatch happens which is same for both UserClient and UserServer
in tests. Patch for DRILL-2674 includes negative tests where user authentication fails in
handshake processing in UserServer.
> 
> 
> Thanks,
> 
> Venki Korukanti
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message