drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mehant Baid" <baid.meh...@gmail.com>
Subject Re: Review Request 31160: DRILL-2244: Implicit cast for join conditions
Date Fri, 03 Apr 2015 00:48:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31160/
-----------------------------------------------------------

(Updated April 3, 2015, 12:48 a.m.)


Review request for drill and Aman Sinha.


Repository: drill-git


Description
-------

If the return type of the two expressions in the join condition are of different types then
we need to inject a cast on one of the sides for comparison functions to work as expected


Diffs (updated)
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/Hash64Functions.java 57154ed

  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/Hash64FunctionsWithSeed.java
b9ec956 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/ChainedHashTable.java
84a2956 
  exec/java-exec/src/main/java/org/apache/drill/exec/resolver/TypeCastRules.java d8652f2 
  exec/java-exec/src/test/java/org/apache/drill/TestFunctionsQuery.java f1005ab 

Diff: https://reviews.apache.org/r/31160/diff/


Testing
-------

Added unit tests with hash join and merge join


Thanks,

Mehant Baid


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message