drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Norris Lee" <norr...@simba.com>
Subject Review Request 32800: C++ Client Authentication API passing std::string across DLL boundaries
Date Thu, 02 Apr 2015 23:46:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32800/
-----------------------------------------------------------

Review request for drill, Alexander zarei, Parth Chandra, and Xiao Meng.


Bugs: DRILL-2671
    https://issues.apache.org/jira/browse/DRILL-2671


Repository: drill-git


Description
-------

DrillUserProperty::setProperty is taking std::string as parameters. Memory gets allocated
in the client yet Drill Client tries to clean it up.


Diffs
-----

  contrib/native/client/example/querySubmitter.cpp bef64bf 
  contrib/native/client/src/clientlib/drillClient.cpp 90aa555 
  contrib/native/client/src/include/drill/drillClient.hpp 9289df3 

Diff: https://reviews.apache.org/r/32800/diff/


Testing
-------


Thanks,

Norris Lee


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message