drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Barclay" <dbarc...@maprtech.com>
Subject Review Request 32713: DRILL-2638: Regularize startup/shutdown logging a bit in/near Drillbit.
Date Wed, 01 Apr 2015 20:55:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32713/
-----------------------------------------------------------

Review request for drill, Jacques Nadeau and Parth Chandra.


Bugs: DRILL-2638
    https://issues.apache.org/jira/browse/DRILL-2638


Repository: drill-git


Description
-------

In Drillbit:
- Added shutdown time (ms).
- Regularized to have bracketing "starting" and "finished" messages (when DEBUG enabled; include
only messages with times at INFO level).  (See examples below.)
- Edited text.
    
In FunctionImplementationRegistry
- DEBUG -> INFO for message with startup time.
- Edited text.
    
(Examples:
At DEBUG level:
    
    ... DEBUG o.apache.drill.exec.server.Drillbit - Starting new Drillbit.
    ... DEBUG o.apache.drill.exec.server.Drillbit - Construction started.
    ... INFO  o.apache.drill.exec.server.Drillbit - Construction completed (1259 ms).
    ... DEBUG o.apache.drill.exec.server.Drillbit - Startup begun.
    ... INFO  o.apache.drill.exec.server.Drillbit - Startup completed (5359 ms).
    ... DEBUG o.apache.drill.exec.server.Drillbit - Started new Drillbit.
    ...
    ... DEBUG o.apache.drill.exec.server.Drillbit - Shutdown begun.
    ... INFO  o.apache.drill.exec.server.Drillbit - Shutdown completed (6346 ms).
    
At INFO level:
    
    ... INFO  o.apache.drill.exec.server.Drillbit - Construction completed (1259 ms).
    ... INFO  o.apache.drill.exec.server.Drillbit - Startup completed (5359 ms).
    ...
    ... INFO  o.apache.drill.exec.server.Drillbit - Shutdown completed (6346 ms).
    
)


Diffs
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionImplementationRegistry.java
e96fa60 
  exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java 958f2dc 

Diff: https://reviews.apache.org/r/32713/diff/


Testing
-------

Ran at INFO vs. DEBUG levels to confirm (manually).

Ran existing tests; no new errors.


Thanks,

Daniel Barclay


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message