Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EA92E17D6A for ; Mon, 30 Mar 2015 21:10:51 +0000 (UTC) Received: (qmail 6561 invoked by uid 500); 30 Mar 2015 21:10:51 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 6503 invoked by uid 500); 30 Mar 2015 21:10:51 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 6492 invoked by uid 500); 30 Mar 2015 21:10:51 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 6484 invoked by uid 99); 30 Mar 2015 21:10:51 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Mar 2015 21:10:51 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 783181C04B1; Mon, 30 Mar 2015 21:10:48 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6838150905261304754==" MIME-Version: 1.0 Subject: Review Request 32640: DRILL-2573: C++ Client - Separate QueryResult into QueryResult and QueryData From: "Parth Chandra" To: "Xiao Meng" , "Alexander zarei" , "Norris Lee" , "Mehant Baid" Cc: "drill" , "Parth Chandra" Date: Mon, 30 Mar 2015 21:10:48 -0000 Message-ID: <20150330211048.16791.32495@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Parth Chandra" X-ReviewGroup: drill-git X-ReviewRequest-URL: https://reviews.apache.org/r/32640/ X-Sender: "Parth Chandra" Reply-To: "Parth Chandra" X-ReviewRequest-Repository: drill-git --===============6838150905261304754== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32640/ ----------------------------------------------------------- Review request for drill, Alexander zarei, Mehant Baid, Norris Lee, and Xiao Meng. Repository: drill-git Description ------- The original QueryResult message has been split into two parts, QueryResult which will carry only status information and QueryData which will contain the actual data. As a part of this change, the server will no longer send back a last_chunk flag with the record batches. The server will guarantee sending back a 'terminal' state message which would be either QUERY_COMPLETED, QUERY_FAILE, or QUERY_CANCELED. To manage this more cleanly, the C++ api no longer maintains a list of cancelled queries. Instead, if a QueryData message for a cancelled query is received, the API simply discards the message. If a QueryResult message for a cancelled query is received the state is updated and the API stops listening for more messages. Diffs ----- contrib/native/client/example/querySubmitter.cpp bef64bf contrib/native/client/src/clientlib/drillClientImpl.hpp 33f81db contrib/native/client/src/clientlib/drillClientImpl.cpp 71f960e contrib/native/client/src/clientlib/recordBatch.cpp 44140b2 contrib/native/client/src/include/drill/common.hpp 6560692 contrib/native/client/src/include/drill/recordBatch.hpp 92a4c3ad contrib/native/client/src/protobuf/BitData.pb.h f1f9353 contrib/native/client/src/protobuf/BitData.pb.cc ef4f99d contrib/native/client/src/protobuf/User.pb.h eca199d contrib/native/client/src/protobuf/User.pb.cc d85c81b contrib/native/client/src/protobuf/UserBitShared.pb.h bbf3fdc contrib/native/client/src/protobuf/UserBitShared.pb.cc 7c237f6 Diff: https://reviews.apache.org/r/32640/diff/ Testing ------- Mac, Win64, Linux 64(with Valgrind) for both sync and async APIs. Incuded queries that had errors, multiple queries in parallel and multiple queries in parallel with errors and cancellations. Thanks, Parth Chandra --===============6838150905261304754==--