Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
Content-Type: multipart/alternative;
 boundary="===============8572140535826697611=="
MIME-Version: 1.0
Subject: Re: Review Request 32523: DRILL-2568: Conditionally drop filter
 during
 partition pruning
From: "Aman Sinha" <asinha@maprtech.com>
To: "Jacques Nadeau" <jacques.drill@gmail.com>
Cc: "Aman Sinha" <asinha@maprtech.com>,
 "drill" <drill-dev@incubator.apache.org>
Date: Sat, 28 Mar 2015 07:46:48 -0000
Message-ID: <20150328074648.1505.99374@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Aman Sinha" <noreply@reviews.apache.org>
References: <20150326034923.15432.36698@reviews.apache.org>
In-Reply-To: <20150326034923.15432.36698@reviews.apache.org>
Reply-To: "Aman Sinha" <asinha@maprtech.com>

--===============8572140535826697611==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32523/
-----------------------------------------------------------

(Updated March 28, 2015, 7:46 a.m.)


Review request for drill and Jacques Nadeau.


Changes
-------

Updating the patch for compeletenss sake; it does not need another review - the main change from the previous patch is that I have added plan checking and results validation checking for several tests in TestPartitionFilter.  Also moved all tests within TestPrune into TestPartitionFilter and removed TestPrune.


Bugs: DRILL-2568
    https://issues.apache.org/jira/browse/DRILL-2568


Repository: drill-git


Description
-------

Drop the filter plan node if all conjuncts in the filter have been pushed as part of partition pruning, except for the situation where the new set of files is empty - we add a single file in that case, so the Filter is preserved in that case.


Diffs (updated)
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/FindPartitionConditions.java 3acf29d 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java 413259d 
  exec/java-exec/src/test/java/org/apache/drill/TestPartitionFilter.java 6b904ec 
  exec/java-exec/src/test/java/org/apache/drill/exec/expr/TestPrune.java d15555e 

Diff: https://reviews.apache.org/r/32523/diff/


Testing
-------

Manual inspection of Explain plans for several types of queries.  Running regression tests..


Thanks,

Aman Sinha


--===============8572140535826697611==--