Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EEAC617BFD for ; Sat, 28 Mar 2015 00:01:21 +0000 (UTC) Received: (qmail 88124 invoked by uid 500); 28 Mar 2015 00:01:21 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 88062 invoked by uid 500); 28 Mar 2015 00:01:21 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 88051 invoked by uid 500); 28 Mar 2015 00:01:21 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 88046 invoked by uid 99); 28 Mar 2015 00:01:21 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 28 Mar 2015 00:01:21 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8D9F21D54C0; Sat, 28 Mar 2015 00:01:20 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7544103709429455661==" MIME-Version: 1.0 Subject: Re: Review Request 32523: DRILL-2568: Conditionally drop filter during partition pruning From: "Jacques Nadeau" To: "Jacques Nadeau" Cc: "Aman Sinha" , "drill" Date: Sat, 28 Mar 2015 00:01:20 -0000 Message-ID: <20150328000120.1504.5765@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jacques Nadeau" X-ReviewGroup: drill-git X-ReviewRequest-URL: https://reviews.apache.org/r/32523/ X-Sender: "Jacques Nadeau" References: <20150326034923.15432.36698@reviews.apache.org> In-Reply-To: <20150326034923.15432.36698@reviews.apache.org> Reply-To: "Jacques Nadeau" X-ReviewRequest-Repository: drill-git --===============7544103709429455661== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32523/#review78132 ----------------------------------------------------------- Ship it! Let's not worry about partial drop. Otherwise, lgtm. +1 - Jacques Nadeau On March 26, 2015, 3:49 a.m., Aman Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32523/ > ----------------------------------------------------------- > > (Updated March 26, 2015, 3:49 a.m.) > > > Review request for drill and Jacques Nadeau. > > > Bugs: DRILL-2568 > https://issues.apache.org/jira/browse/DRILL-2568 > > > Repository: drill-git > > > Description > ------- > > Drop the filter plan node if all conjuncts in the filter have been pushed as part of partition pruning, except for the situation where the new set of files is empty - we add a single file in that case, so the Filter is preserved in that case. > > > Diffs > ----- > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java b8c9ebf > exec/java-exec/src/test/java/org/apache/drill/exec/expr/TestPrune.java d15555e > > Diff: https://reviews.apache.org/r/32523/diff/ > > > Testing > ------- > > Manual inspection of Explain plans for several types of queries. Running regression tests.. > > > Thanks, > > Aman Sinha > > --===============7544103709429455661==--