Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 59D6917BCF for ; Thu, 19 Mar 2015 18:32:03 +0000 (UTC) Received: (qmail 36947 invoked by uid 500); 19 Mar 2015 18:31:57 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 36886 invoked by uid 500); 19 Mar 2015 18:31:56 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 36875 invoked by uid 500); 19 Mar 2015 18:31:56 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 36869 invoked by uid 99); 19 Mar 2015 18:31:56 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Mar 2015 18:31:56 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A5AEB1D44E2; Thu, 19 Mar 2015 18:31:55 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1000649662589162690==" MIME-Version: 1.0 Subject: Re: Review Request 32248: DRILL-2139: Star is not expanded correctly in "select distinct" query From: "Sean Hsuan-Yi Chu" To: "Aman Sinha" , "Jinfeng Ni" Cc: "Sean Hsuan-Yi Chu" , "drill" Date: Thu, 19 Mar 2015 18:31:55 -0000 Message-ID: <20150319183155.19861.69074@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Sean Hsuan-Yi Chu" X-ReviewGroup: drill-git X-ReviewRequest-URL: https://reviews.apache.org/r/32248/ X-Sender: "Sean Hsuan-Yi Chu" References: <20150319180518.19861.61800@reviews.apache.org> In-Reply-To: <20150319180518.19861.61800@reviews.apache.org> Reply-To: "Sean Hsuan-Yi Chu" X-ReviewRequest-Repository: drill-git --===============1000649662589162690== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32248/ ----------------------------------------------------------- (Updated March 19, 2015, 6:31 p.m.) Review request for drill, Aman Sinha and Jinfeng Ni. Changes ------- QA tests passed Bugs: DRILL-2139 https://issues.apache.org/jira/browse/DRILL-2139 Repository: drill-git Description ------- Expand * at the run time Diffs ----- exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggBatch.java c29fbf2 exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/StreamingAggBatch.java 33d2c7a exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java a23780e exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java d2d97f8 exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/agg/TestHashAggr.java 3786bfd exec/java-exec/src/test/resources/store/text/data/repeatedRows.json PRE-CREATION Diff: https://reviews.apache.org/r/32248/diff/ Testing (updated) ------- Unit and all QA tests passed. Thanks, Sean Hsuan-Yi Chu --===============1000649662589162690==--