Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 64E0917D35 for ; Thu, 12 Mar 2015 04:06:02 +0000 (UTC) Received: (qmail 67630 invoked by uid 500); 12 Mar 2015 04:06:02 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 67568 invoked by uid 500); 12 Mar 2015 04:06:02 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 67555 invoked by uid 500); 12 Mar 2015 04:06:01 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 67549 invoked by uid 99); 12 Mar 2015 04:06:01 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Mar 2015 04:06:01 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id F012C1D3DD3; Thu, 12 Mar 2015 04:05:59 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4606374322390811229==" MIME-Version: 1.0 Subject: Re: Review Request 31953: DRILL-2128: Pt. 1: Preparatory changes before core changes for actual fix. From: "Parth Chandra" To: "Parth Jagirdar" Cc: "Daniel Barclay" , "drill" , "Parth Chandra" Date: Thu, 12 Mar 2015 04:05:59 -0000 Message-ID: <20150312040559.14617.98949@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Parth Chandra" X-ReviewGroup: drill-git X-ReviewRequest-URL: https://reviews.apache.org/r/31953/ X-Sender: "Parth Chandra" References: <20150311220903.14616.2471@reviews.apache.org> In-Reply-To: <20150311220903.14616.2471@reviews.apache.org> Reply-To: "Parth Chandra" X-ReviewRequest-Repository: drill-git --===============4606374322390811229== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31953/#review76204 ----------------------------------------------------------- Ship it! Ship It! - Parth Chandra On March 11, 2015, 10:09 p.m., Daniel Barclay wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31953/ > ----------------------------------------------------------- > > (Updated March 11, 2015, 10:09 p.m.) > > > Review request for drill and Parth Jagirdar. > > > Repository: drill-git > > > Description > ------- > > Added comments showing getColumns() column number and missing/misnamed columns. > Aligned SQL (Java strings and net SQL). > > > Diffs > ----- > > exec/jdbc/src/main/java/org/apache/drill/jdbc/MetaImpl.java 0ea8d5c > > Diff: https://reviews.apache.org/r/31953/diff/ > > > Testing > ------- > > Ran tests. > > > Thanks, > > Daniel Barclay > > --===============4606374322390811229==--