Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
Content-Type: multipart/alternative;
 boundary="===============4825442074624182445=="
MIME-Version: 1.0
Subject: Re: Review Request 31871: 2406 - part 2 - (subset of 2060 part 2)
 enable interpreted expression evaluation at planning time
From: "Jacques Nadeau" <jacques.drill@gmail.com>
To: "Jacques Nadeau" <jacques.drill@gmail.com>
Cc: "Jason Altekruse" <altekrusejason@gmail.com>,
 "drill" <drill-dev@incubator.apache.org>
Date: Tue, 10 Mar 2015 04:45:39 -0000
Message-ID: <20150310044539.17900.10710@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Jacques Nadeau" <noreply@reviews.apache.org>
References: <20150309220727.17900.27116@reviews.apache.org>
In-Reply-To: <20150309220727.17900.27116@reviews.apache.org>
Reply-To: "Jacques Nadeau" <jacques.drill@gmail.com>

--===============4825442074624182445==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31871/#review75851
-----------------------------------------------------------


exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java
<https://reviews.apache.org/r/31871/#comment123169>

    Seems like this should be Exception, not just IOException.


exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java
<https://reviews.apache.org/r/31871/#comment123170>

    Does this work correct in relationship to sendResult?  It seems like if everything was okay but then we failed just above, we should send a failure rather than a success result.


- Jacques Nadeau


On March 9, 2015, 10:07 p.m., Jason Altekruse wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31871/
> -----------------------------------------------------------
> 
> (Updated March 9, 2015, 10:07 p.m.)
> 
> 
> Review request for drill and Jacques Nadeau.
> 
> 
> Bugs: DRILL-2406
>     https://issues.apache.org/jira/browse/DRILL-2406
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> To enable planning rules to take advantage of constant expressions in queries, or to allow them to run queries against small datasets, such as partition information we need to e able to evaluate expressions at planning time. Expression evaluation in the regular expecuation path is relatively expensive, as it invovles java code generation, compilation and JITing expression trees. An interpreted expression system was added recently to allow evaluating an expression without generating java code at runtime. This patch exposes that work (after some refactorings in 2143 and the first part of 2406) to the planning context for use in optimizer rules.
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java 00aaec6 
>   exec/java-exec/src/main/java/org/apache/drill/exec/memory/TopLevelAllocator.java 2a28bcb 
>   exec/java-exec/src/main/java/org/apache/drill/exec/ops/BufferManager.java PRE-CREATION 
>   exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java aa1dffd 
>   exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java c881432 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillReduceAggregatesRule.java 93fff35 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/InsertLocalExchangeVisitor.java 907fcb1 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlOperator.java 6b54c43 
>   exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java 409450f 
> 
> Diff: https://reviews.apache.org/r/31871/diff/
> 
> 
> Testing
> -------
> 
> Cluster tests completed, waiting on unit tests.
> 
> 
> Thanks,
> 
> Jason Altekruse
> 
>


--===============4825442074624182445==--