Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B696010A4F for ; Tue, 10 Mar 2015 00:21:17 +0000 (UTC) Received: (qmail 69159 invoked by uid 500); 10 Mar 2015 00:20:55 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 69103 invoked by uid 500); 10 Mar 2015 00:20:55 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 69092 invoked by uid 500); 10 Mar 2015 00:20:55 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 69085 invoked by uid 99); 10 Mar 2015 00:20:55 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Mar 2015 00:20:55 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9F0041D3A4F; Tue, 10 Mar 2015 00:20:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1591286007978314799==" MIME-Version: 1.0 Subject: Re: Review Request 30807: DRILL-2012: Flatten fails when we filter by a non-projected column From: "Sean Hsuan-Yi Chu" To: "Aman Sinha" , "Jason Altekruse" , "Jinfeng Ni" Cc: "Sean Hsuan-Yi Chu" , "drill" Date: Tue, 10 Mar 2015 00:20:53 -0000 Message-ID: <20150310002053.17901.49969@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Sean Hsuan-Yi Chu" X-ReviewGroup: drill-git X-ReviewRequest-URL: https://reviews.apache.org/r/30807/ X-Sender: "Sean Hsuan-Yi Chu" References: <20150305003229.5896.94623@reviews.apache.org> In-Reply-To: <20150305003229.5896.94623@reviews.apache.org> Reply-To: "Sean Hsuan-Yi Chu" X-ReviewRequest-Repository: drill-git --===============1591286007978314799== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30807/ ----------------------------------------------------------- (Updated March 10, 2015, 12:20 a.m.) Review request for drill, Aman Sinha, Jason Altekruse, and Jinfeng Ni. Changes ------- clean code Bugs: DRILL-2012 https://issues.apache.org/jira/browse/DRILL-2012 Repository: drill-git Description ------- Mainly rewrote visitProject in SplitUpComplexExpressions Diffs (updated) ----- exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/SplitUpComplexExpressions.java 11b6c43 exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/flatten/TestFlatten.java dc37079 exec/java-exec/src/test/resources/store/text/sample.json PRE-CREATION Diff: https://reviews.apache.org/r/30807/diff/ Testing ------- Unit, functional, tpch tests passed Thanks, Sean Hsuan-Yi Chu --===============1591286007978314799==--