Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 768241777E for ; Sat, 7 Mar 2015 01:49:08 +0000 (UTC) Received: (qmail 26046 invoked by uid 500); 7 Mar 2015 01:49:02 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 25985 invoked by uid 500); 7 Mar 2015 01:49:01 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 25974 invoked by uid 500); 7 Mar 2015 01:49:01 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 25968 invoked by uid 99); 7 Mar 2015 01:49:01 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 07 Mar 2015 01:49:01 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 552A71D3990; Sat, 7 Mar 2015 01:49:00 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5756640685658359169==" MIME-Version: 1.0 Subject: Review Request 31822: DRILL-2402: Updating hash functions so that combination hashing uses a chained approach rather than xor From: "Jacques Nadeau" To: "Mehant Baid" , "Aman Sinha" Cc: "Jacques Nadeau" , "drill" Date: Sat, 07 Mar 2015 01:49:00 -0000 Message-ID: <20150307014900.12263.91425@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jacques Nadeau" X-ReviewGroup: drill-git X-ReviewRequest-URL: https://reviews.apache.org/r/31822/ X-Sender: "Jacques Nadeau" Reply-To: "Jacques Nadeau" X-ReviewRequest-Repository: drill-git --===============5756640685658359169== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31822/ ----------------------------------------------------------- Review request for drill, Aman Sinha and Mehant Baid. Repository: drill-git Description ------- Add hash64(val) and hash64(val, seed) and use for all distribution and hash table purposes. Diffs ----- exec/java-exec/src/main/java/org/apache/drill/exec/expr/ExpressionTreeMaterializer.java 3565bf4 exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/Hash64Functions.java PRE-CREATION exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/Hash64FunctionsWithSeed.java PRE-CREATION exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/HashFunctions.java 9658fdb exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/XXHash.java 8ad9611 exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/ChainedHashTable.java 8f921f7 exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/PrelUtil.java 1adc54f Diff: https://reviews.apache.org/r/31822/diff/ Testing ------- Thanks, Jacques Nadeau --===============5756640685658359169==--