drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Hsuan-Yi Chu" <hsua...@usc.edu>
Subject Re: Review Request 32496: DRILL-2559: In case where windows are disabled but used, throw UnsupportedFunctionException
Date Tue, 31 Mar 2015 22:36:49 GMT


> On March 31, 2015, 7 a.m., Aman Sinha wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java,
line 140
> > <https://reviews.apache.org/r/32496/diff/1/?file=906007#file906007line140>
> >
> >     I don't see why this refers to DRILL-1921 which does not mention window function
anywhere.. that JIRA only talks about set operations and crossjoin and in fact is already
'fixed'.  If a user got the 'window functions are disabled' error message and went to DRILL-1921
they would get quite confused.  You should refer to a bug that is specific to WF and is NOT
in a fixed status.

Fixed it ! Updated a new patch


- Sean Hsuan-Yi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32496/#review78356
-----------------------------------------------------------


On March 31, 2015, 4:58 p.m., Sean Hsuan-Yi Chu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32496/
> -----------------------------------------------------------
> 
> (Updated March 31, 2015, 4:58 p.m.)
> 
> 
> Review request for drill, abdelhakim deneche and Aman Sinha.
> 
> 
> Bugs: DRILL-2559
>     https://issues.apache.org/jira/browse/DRILL-2559
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> In case where windows are disabled but used, throw UnsupportedFunctionException
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/window/OverFinder.java
40e5920 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DefaultSqlHandler.java
e908538 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java
46fb925 
>   exec/java-exec/src/test/java/org/apache/drill/TestDisabledFunctionality.java f64d3e5

> 
> Diff: https://reviews.apache.org/r/32496/diff/
> 
> 
> Testing
> -------
> 
> unit test, QA passed!
> 
> 
> Thanks,
> 
> Sean Hsuan-Yi Chu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message