drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Barclay" <dbarc...@maprtech.com>
Subject Re: Review Request 32593: DRILL-2579: pt 1. Core fix: Fix: JDBC unit tests will time out after one testcase fails with unexpected results.
Date Tue, 31 Mar 2015 18:24:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32593/#review78384
-----------------------------------------------------------



exec/jdbc/src/test/java/org/apache/drill/jdbc/SingleConnectionCachingFactory.java
<https://reviews.apache.org/r/32593/#comment126989>

    Ping?


- Daniel Barclay


On March 28, 2015, 4:32 a.m., Daniel Barclay wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32593/
> -----------------------------------------------------------
> 
> (Updated March 28, 2015, 4:32 a.m.)
> 
> 
> Review request for drill, Mehant Baid and Parth Chandra.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Nulled out member to avoid re-using closed Connection.
> 
> 
> Diffs
> -----
> 
>   exec/jdbc/src/test/java/org/apache/drill/jdbc/SingleConnectionCachingFactory.java 88fb4c6

> 
> Diff: https://reviews.apache.org/r/32593/diff/
> 
> 
> Testing
> -------
> 
> Manual:  Broke a JDBC JUnit test, ran it, saw hang, applied fix line, ran again, saw
hang gone.
> 
> Ran existing tests.
> 
> 
> Thanks,
> 
> Daniel Barclay
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message