drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Barclay" <dbarc...@maprtech.com>
Subject Review Request 32494: DRILL-2565: Add AlreadyClosedSqlException, some key checks, and test for future DRILL-2489 fix.
Date Tue, 31 Mar 2015 18:17:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32494/
-----------------------------------------------------------

Review request for drill, Mehant Baid and Parth Chandra.


Repository: drill-git


Description
-------

- Created AlreadyClosedSqlException.
- (Moved JdbcApiSqlException to be subclass of SQLNonTransientException.)
- Created test Drill2489CallsAfterCloseThrowExceptionsTest for eventual fixing of DRILL-2489.
   - (Is partial:  Covers Connection, Statement, and ResultSet.)
   - (Is interim:  Most methods' test disabled with @Ignore.)
- Added already-closed checking in key places, especially those that involve communication
and could hang for a while rather than dying quickly (e.g., Statement.execute...(...)).


Diffs
-----

  exec/jdbc/src/main/java/org/apache/drill/jdbc/AlreadyClosedSqlException.java PRE-CREATION

  exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java e590778 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillDatabaseMetaData.java ca1648d 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java 0ce33f4 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillStatement.java d934c7c 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/InvalidCursorStateSqlException.java 7b04371

  exec/jdbc/src/main/java/org/apache/drill/jdbc/JdbcApiSqlException.java d6b05fb 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2489CallsAfterCloseThrowExceptionsTest.java
PRE-CREATION 

Diff: https://reviews.apache.org/r/32494/diff/


Testing
-------

Ran new specific tests.

Run existing tests; no new problems.


Thanks,

Daniel Barclay


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message