drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steven Phillips" <sphill...@maprtech.com>
Subject Re: Review Request 31748: DRILL-2387: Enhance exception reporting
Date Mon, 30 Mar 2015 18:51:25 GMT


> On March 26, 2015, 11:58 p.m., Parth Chandra wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/work/ErrorHelper.java, line 78
> > <https://reviews.apache.org/r/31748/diff/4/?file=897849#file897849line78>
> >
> >     Since we're cleaning this up, I really thing a UUID for the client side error
message only serves to confuse the message and we should ideally remove it.
> 
> Jacques Nadeau wrote:
>     In the non verbose case, I agree that it can probably be hidden.  However, in verbose
error mode, the error id gives someone a handle to find the error event and surrounding events
in the log.  In debugging production clusters we use it extensively.

The error ID is actually the most important part of the error message, and I think it should
be there even in the non-verbose case.


- Steven


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31748/#review77978
-----------------------------------------------------------


On March 20, 2015, 4:15 p.m., Sudheesh Katkam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31748/
> -----------------------------------------------------------
> 
> (Updated March 20, 2015, 4:15 p.m.)
> 
> 
> Review request for drill and Jason Altekruse.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Gather messages while unwrapping an exception 
> 
> (+ color to sqlline in default mode)
> 
> 
> Diffs
> -----
> 
>   distribution/src/resources/sqlline 0852fba 
>   exec/java-exec/src/main/java/org/apache/drill/exec/work/ErrorHelper.java 0773d6c 
>   exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java 378e81a

>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillCursor.java fbe611f 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java 77b2c37 
> 
> Diff: https://reviews.apache.org/r/31748/diff/
> 
> 
> Testing
> -------
> 
> input.json has an integer with a leading zero:
> 
> Currently the error message shows:
> ```
> $ select * from cp.`jsoninput/input.json`;
> Exception (no rows returned): org.apache.drill.exec.rpc.RpcException: Query stopped.
> Invalid numeric value: Leading zeroes not allowed
>  at [Source: org.apache.drill.exec.vector.complex.fn.JsonReader@d4ef9fe; line: 0, column:
16]
> [Error c50f1dd4-c3b6-4185-8c65-27cf34edf1a2 on 192.168.168.91:31013 ]
> ```
> 
> Set the verbose flag to see:
> ```
> $ alter session set `exec.errors.verbose`=true;
> $ select * from cp.`jsoninput/input.json`;
> Exception (no rows returned): org.apache.drill.exec.rpc.RpcException: Query stopped.
> ->Error parsing JSON. - Parser was at record: 1 column: 16
> -->Invalid numeric value: Leading zeroes not allowed
>  at [Source: org.apache.drill.exec.vector.complex.fn.JsonReader@307f7f7b; line: 0, column:
16]
> [Error 63196117-3008-4c26-9526-9cca1713406d on 192.168.168.91:31013 ]
> 
>   (org.apache.drill.common.exceptions.DrillRuntimeException) Error parsing JSON. - Parser
was at record: 1 column: 16
>     org.apache.drill.exec.store.easy.json.JSONRecordReader.handleAndRaise():102
>     org.apache.drill.exec.store.easy.json.JSONRecordReader.next():149
>     org.apache.drill.exec.physical.impl.ScanBatch.next():165
>     org.apache.drill.exec.physical.impl.validate.IteratorValidatorBatchIterator.next():118
>     org.apache.drill.exec.physical.impl.BaseRootExec.next():67
>     org.apache.drill.exec.physical.impl.ScreenCreator$ScreenRoot.innerNext():97
>     org.apache.drill.exec.physical.impl.BaseRootExec.next():57
>     org.apache.drill.exec.work.fragment.FragmentExecutor.run():121
>     org.apache.drill.exec.work.WorkManager$RunnableWrapper.run():303
>     .......():0
>   Caused By (com.fasterxml.jackson.core.JsonParseException) Invalid numeric value: Leading
zeroes not allowed
>  at [Source: org.apache.drill.exec.vector.complex.fn.JsonReader@307f7f7b; line: 0, column:
16]
>     com.fasterxml.jackson.core.JsonParser._constructError():1419
>     com.fasterxml.jackson.core.base.ParserMinimalBase._reportError():508
>     com.fasterxml.jackson.core.base.ParserBase.reportInvalidNumber():943
>     com.fasterxml.jackson.core.json.UTF8StreamJsonParser._verifyNoLeadingZeroes():1348
>     com.fasterxml.jackson.core.json.UTF8StreamJsonParser._parsePosNumber():1195
>     com.fasterxml.jackson.core.json.UTF8StreamJsonParser.nextToken():726
>     org.apache.drill.exec.vector.complex.fn.JsonReader.writeData():240
>     org.apache.drill.exec.vector.complex.fn.JsonReader.writeDataSwitch():208
>     org.apache.drill.exec.vector.complex.fn.JsonReader.writeToVector():182
>     org.apache.drill.exec.vector.complex.fn.JsonReader.write():156
>     org.apache.drill.exec.store.easy.json.JSONRecordReader.next():125
>     org.apache.drill.exec.physical.impl.ScanBatch.next():165
>     org.apache.drill.exec.physical.impl.validate.IteratorValidatorBatchIterator.next():118
>     org.apache.drill.exec.physical.impl.BaseRootExec.next():67
>     org.apache.drill.exec.physical.impl.ScreenCreator$ScreenRoot.innerNext():97
>     org.apache.drill.exec.physical.impl.BaseRootExec.next():57
>     org.apache.drill.exec.work.fragment.FragmentExecutor.run():121
>     org.apache.drill.exec.work.WorkManager$RunnableWrapper.run():303
>     .......():0
> ```
> 
> 
> Thanks,
> 
> Sudheesh Katkam
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message