drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mehant Baid" <baid.meh...@gmail.com>
Subject Re: Review Request 32524: DRILL-2375: implement reader reset mechanism and reset reader before accessing it during projection
Date Mon, 30 Mar 2015 16:07:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32524/#review78210
-----------------------------------------------------------

Ship it!


Ship It!

- Mehant Baid


On March 26, 2015, 4:10 a.m., Hanifi Gunes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32524/
> -----------------------------------------------------------
> 
> (Updated March 26, 2015, 4:10 a.m.)
> 
> 
> Review request for drill, Mehant Baid and Parth Chandra.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> DRILL-2375: implement reader reset mechanism and reset reader before accessing it during
projection
> 
> Drill readers are stateful. In case multiple projections are made from a repeated vector,
its child index should be reset before iterating over child elements. This patch introduces
a reader reset mechanism and resets readers prior to their use in project.
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/codegen/templates/BaseReader.java 9281d3ce2cdad67c422be7ec9624c24e1595accd

>   exec/java-exec/src/main/java/org/apache/drill/exec/expr/EvaluationVisitor.java a5758fba9a0e3fa53aaaaa6ca7c3b0cca1b322d7

>   exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/AbstractBaseReader.java
04235fa51a648e498054cc8c8be6a9c6b47fb791 
>   exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/RepeatedListReaderImpl.java
c51dfda69a568e3877e1edb75b179870987ecff8 
>   exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/RepeatedMapReaderImpl.java
91362770c3265104876f772f4f50441b6e33dc4d 
>   exec/java-exec/src/test/java/org/apache/drill/exec/expr/TestSchemaPathMaterialization.java
fb4cad9f1b1dbe5f3f30734fa28052a2e0fa80af 
> 
> Diff: https://reviews.apache.org/r/32524/diff/
> 
> 
> Testing
> -------
> 
> unit + regression
> 
> 
> Thanks,
> 
> Hanifi Gunes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message