drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Barclay" <dbarc...@maprtech.com>
Subject Review Request 32598: DRILL-2579: pt 2. Hygiene: Renamed to match semantics; fixed, added, formatted doc.; basic whitespace.
Date Sat, 28 Mar 2015 04:55:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32598/
-----------------------------------------------------------

Review request for drill, Mehant Baid and Parth Chandra.


Repository: drill-git


Description
-------

- Renamed createConnection -> getConnection (since isn't necessarily a new connection).
- Renamed close -> closeConnections (since not closing the factory but its connections).
- Added documentation fixes, clarifications, formatting.
- Fixed some basic whitespace.


Diffs
-----

  exec/jdbc/src/test/java/org/apache/drill/jdbc/CachingConnectionFactory.java df64366 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/ConnectionFactory.java 8491436 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/JdbcTest.java 6d8d8e9 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/MultiConnectionCachingFactory.java 189942d

  exec/jdbc/src/test/java/org/apache/drill/jdbc/NonClosableConnection.java 1e37700 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/SingleConnectionCachingFactory.java 88fb4c6

  exec/jdbc/src/test/java/org/apache/drill/jdbc/test/JdbcAssert.java f7ecf0a 

Diff: https://reviews.apache.org/r/32598/diff/


Testing
-------

Ran existing tests.


Thanks,

Daniel Barclay


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message