drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Venki Korukanti" <venki.koruka...@gmail.com>
Subject Re: Review Request 32404: DRILL-2514: Add support for impersonation in FileSystem storage plugin
Date Fri, 27 Mar 2015 16:47:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32404/
-----------------------------------------------------------

(Updated March 27, 2015, 4:47 p.m.)


Review request for drill and Jacques Nadeau.


Changes
-------

Added unittests based on Hadoop MiniDFS cluster

Also:
- Upgrade slf4j version to 1.7.6 from 1.7.5 to have a fix/improvement in log4j-over-slf4j
needed for log4j code in MiniDFS cluster


Repository: drill-git


Description
-------

Please see JIRA DRILL-2514 for details.


Diffs (updated)
-----

  contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseSchemaFactory.java
7b76092 
  contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseStoragePlugin.java
c10b0ab 
  contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveStoragePlugin.java
f4baf3b 
  contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveSubScan.java
c06502e 
  contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/HiveSchemaFactory.java
023517b 
  contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoStoragePlugin.java
e46d8ec 
  contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/schema/MongoSchemaFactory.java
32c42ba 
  distribution/src/resources/drill-override-example.conf 4cd342a 
  exec/java-exec/pom.xml dfb1a6b 
  exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java 14e6ad1 
  exec/java-exec/src/main/java/org/apache/drill/exec/dotdrill/DotDrillFile.java 6a5934b 
  exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java a4ac724 
  exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java 3b51a69 
  exec/java-exec/src/main/java/org/apache/drill/exec/ops/ViewExpansionContext.java PRE-CREATION

  exec/java-exec/src/main/java/org/apache/drill/exec/opt/BasicOptimizer.java b1a71a5 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractBase.java defb4e4

  exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/PhysicalOperator.java a5518ca

  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ImplCreator.java e25f1c0

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillTable.java c8f872e

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillViewTable.java 68e666a

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DynamicDrillTable.java
843db58 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/torel/ConversionContext.java
a486369 
  exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java
608fac7 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/AbstractStoragePlugin.java b032fce

  exec/java-exec/src/main/java/org/apache/drill/exec/store/SchemaFactory.java feadabd 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePlugin.java ef5978c 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistry.java 5d0eed6

  exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemPlugin.java 7a1f61e

  exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemSchemaFactory.java
4a3eba9 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FormatPlugin.java 58d5b42 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java
7c8d9b3 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/easy/EasyFormatPlugin.java
6e1e0cc 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/easy/EasyGroupScan.java 54cad56

  exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/easy/EasySubScan.java e78ba0b

  exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/TextFormatPlugin.java
bf46395 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/InfoSchemaStoragePlugin.java
77c6b9a 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/MockStorageEngine.java 51b2208

  exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetFormatPlugin.java
e204a2c 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java acac61f

  exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetRowGroupScan.java
fd40f41 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetScanBatchCreator.java
c1f815e 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/SystemTablePlugin.java 13e0ff6

  exec/java-exec/src/main/java/org/apache/drill/exec/util/ImpersonationUtil.java PRE-CREATION

  exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java 285b75a 
  exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java a7e6c46

  exec/java-exec/src/main/resources/drill-module.conf af225c4 
  exec/java-exec/src/test/java/org/apache/drill/BaseTestQuery.java 64cf2ec 
  exec/java-exec/src/test/java/org/apache/drill/PlanningBase.java e673230 
  exec/java-exec/src/test/java/org/apache/drill/QueryTestUtil.java 3d19229 
  exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/BaseTestImpersonation.java
PRE-CREATION 
  exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/TestImpersonationMetadata.java
PRE-CREATION 
  exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/TestImpersonationQueries.java
PRE-CREATION 
  exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestLocalExchange.java
08655e3 
  exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestOptiqPlans.java 6bf23ec

  exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/partitionsender/TestPartitionSender.java
bdb020b 
  exec/java-exec/src/test/java/org/apache/drill/exec/server/TestDrillbitResilience.java 9bc0552

  pom.xml 8c9f09e 

Diff: https://reviews.apache.org/r/32404/diff/


Testing
-------

Manually tested. Unittests with MiniDFS are coming in next patch.


Thanks,

Venki Korukanti


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message