drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sudheesh Katkam" <skat...@maprtech.com>
Subject Re: Review Request 32327: DRILL-2437: enhance exception injection to support session level injections
Date Thu, 26 Mar 2015 23:07:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32327/
-----------------------------------------------------------

(Updated March 26, 2015, 11:07 p.m.)


Review request for drill and Chris Westin.


Changes
-------

Added review changes suggested by chris.


Repository: drill-git


Description
-------

[DRILL-2437](https://issues.apache.org/jira/browse/DRILL-2437): Moved SimulatedExceptions
to UserSession

+ [DRILL-2382](https://issues.apache.org/jira/browse/DRILL-2382): Added address and port to
InjectionOption to specify drillbit
+ JSONStringValidator to TypeValidators


Diffs (updated)
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java cd0a0a2 
  exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java efb0cdf 
  exec/java-exec/src/main/java/org/apache/drill/exec/server/DrillbitContext.java dbf3c74 
  exec/java-exec/src/main/java/org/apache/drill/exec/server/options/TypeValidators.java b9721cc

  exec/java-exec/src/main/java/org/apache/drill/exec/testing/ExceptionInjector.java 54bc351

  exec/java-exec/src/main/java/org/apache/drill/exec/testing/SimulatedExceptions.java 0292c08

  exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java bfb6de8 
  exec/java-exec/src/test/java/org/apache/drill/exec/server/TestDrillbitResilience.java 9bc0552

  exec/java-exec/src/test/java/org/apache/drill/exec/testing/ExceptionInjectionUtil.java bf93dee

  exec/java-exec/src/test/java/org/apache/drill/exec/testing/TestExceptionInjection.java d0c0279


Diff: https://reviews.apache.org/r/32327/diff/


Testing
-------

Added test case.

Passes all other tests, and builds.


Thanks,

Sudheesh Katkam


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message