drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hanifi Gunes" <hanifigu...@gmail.com>
Subject Re: Review Request 32335: DRILL-2366: accurately materialize schema path for complex types + test cases
Date Tue, 24 Mar 2015 23:18:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32335/
-----------------------------------------------------------

(Updated March 24, 2015, 11:18 p.m.)


Review request for drill and Mehant Baid.


Changes
-------

Change list:
- Refactored the patch so that parts relevant to RepeatedMap lives under RepeatedMap.
- Fixed an issue in VectorWrapper implementations regarding child vector look-up to handle
repeated map as well.

Testing: unit + regression.


Repository: drill-git


Description
-------

The changes cover
- Fix schema path materialization for complex types.
- Add unit tests


Diffs (updated)
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/record/HyperVectorWrapper.java 9dbb583cc85d2ba20a99fa82a5484e314b981f62

  exec/java-exec/src/main/java/org/apache/drill/exec/record/SimpleVectorWrapper.java 5bd3e41d8c51bec55e109e6245c385ba5089cf26

  exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/AbstractContainerVector.java
3bc7d11b9d7bf7f3159041ac2235333519d17931 
  exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/MapVector.java b99546253ffd8fe0eb56dc95ec76f5b4bb16a1dc

  exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedMapVector.java
c7e7cbab12f56c0ff571733e61263c380891d5b5 
  exec/java-exec/src/test/java/org/apache/drill/exec/expr/TestSchemaPathMaterialization.java
PRE-CREATION 
  exec/java-exec/src/test/resources/complex/json/repeated_list.json PRE-CREATION 
  exec/java-exec/src/test/resources/complex/json/repeated_list_map.json PRE-CREATION 

Diff: https://reviews.apache.org/r/32335/diff/


Testing
-------

unit + regression


Thanks,

Hanifi Gunes


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message