drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Hsuan-Yi Chu" <hsua...@usc.edu>
Subject Re: Review Request 32354: DRILL-2094: Add SqlOrderBy rule for CompoundIdentifierConverter
Date Mon, 23 Mar 2015 23:50:02 GMT


> On March 23, 2015, 10 p.m., Mehant Baid wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/CompoundIdentifierConverter.java,
line 137
> > <https://reviews.apache.org/r/32354/diff/1/?file=902065#file902065line137>
> >
> >     four data fields
> 
> Sean Hsuan-Yi Chu wrote:
>     Revised comment; 
>     One test case added!

My branch: https://github.com/hsuanyi/incubator-drill/tree/DRILL-2094 
jira: https://issues.apache.org/jira/browse/DRILL-2094 (please +1)


- Sean Hsuan-Yi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32354/#review77472
-----------------------------------------------------------


On March 23, 2015, 11:48 p.m., Sean Hsuan-Yi Chu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32354/
> -----------------------------------------------------------
> 
> (Updated March 23, 2015, 11:48 p.m.)
> 
> 
> Review request for drill and Mehant Baid.
> 
> 
> Bugs: DRILL-2094
>     https://issues.apache.org/jira/browse/DRILL-2094
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Add SqlOrderBy rule for CompoundIdentifierConverter
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/CompoundIdentifierConverter.java
061524d 
>   exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java d2d97f8 
>   exec/java-exec/src/test/resources/store/json/orderByArrayElement.json PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/32354/diff/
> 
> 
> Testing
> -------
> 
> unit,
> fucntional (except 28 expected plan failures in the partition_pruning suite),
> tpch
> 
> all passed
> 
> 
> Thanks,
> 
> Sean Hsuan-Yi Chu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message