drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aman Sinha" <asi...@maprtech.com>
Subject Re: Review Request 32273: DRILL-2408: Invalid (0 length) parquet file created by CTAS
Date Fri, 20 Mar 2015 02:33:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32273/#review77163
-----------------------------------------------------------



exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetRecordWriter.java
<https://reviews.apache.org/r/32273/#comment125038>

    You should also check fs.exists(path) before calling delete.


- Aman Sinha


On March 20, 2015, 12:51 a.m., abdelhakim deneche wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32273/
> -----------------------------------------------------------
> 
> (Updated March 20, 2015, 12:51 a.m.)
> 
> 
> Review request for drill, Aman Sinha and Jason Altekruse.
> 
> 
> Bugs: DRILL-2408
>     https://issues.apache.org/jira/browse/DRILL-2408
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> I updated ParquetRecordWriter to delete the last file created if it's empty (no records
written to it). I also added two unit tests one that checks the default case where we try
to create a table using a query that returns 0 rows, the second case can happen if the ParquetRecordWriter
flushes it's content just after writing the last record, it will then create a new empty file.
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetRecordWriter.java
8bf9a92 
>   exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java d2d97f8 
>   exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java 520c204 
>   exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java
76328c6 
> 
> Diff: https://reviews.apache.org/r/32273/diff/
> 
> 
> Testing
> -------
> 
> - Added 2 unit tests to TestParquetWriter
> - Unit tests are passing
> 
> 
> Thanks,
> 
> abdelhakim deneche
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message