drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Parth Chandra" <pchan...@maprtech.com>
Subject Re: Review Request 28686: For DRILL-1735, hook up JDBC connection closing, and fix follow-on resource bugs.
Date Fri, 20 Mar 2015 01:58:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28686/#review77154
-----------------------------------------------------------

Ship it!


Perhaps we could change the behavior so that the connection object adds and removes statements
from the registry (instead of the statements doing so themselves). Makes the code cleaner.
Not a showstopper for this patch.

- Parth Chandra


On March 20, 2015, 12:30 a.m., Daniel Barclay wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28686/
> -----------------------------------------------------------
> 
> (Updated March 20, 2015, 12:30 a.m.)
> 
> 
> Review request for drill, Mehant Baid and Parth Chandra.
> 
> 
> Bugs: DRILL-1735
>     https://issues.apache.org/jira/browse/DRILL-1735
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> This change hooks in the previously written but unused DrillHandler so that a local-mode
JDBC connection shuts down its embedded DrillBit. 
> 
> It also fixes a chain of follow-on bugs (mostly resource-deallocation omissions) exposed
by the original bug fixes.  (See the commit message for the list of bugs/fixes and other changes.)
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java c3a873c

>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScreenCreator.java
2d1a136 
>   exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/QueryResultHandler.java
b079428 
>   exec/java-exec/src/main/java/org/apache/drill/exec/server/BootStrapContext.java 3da2ea9

>   exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java b606707 
>   exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/SqlAccessor.java
b8480b4 
>   exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java 9650ee5

>   exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java
b6176db 
>   exec/java-exec/src/test/java/org/apache/drill/exec/ExecTest.java 0272b23 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/AvaticaDrillSqlAccessor.java cf5829a

>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillAccessorList.java 82d51f1 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionConfig.java 54e31b1 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java f19aab0 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillCursor.java fbe611f 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillPreparedStatement.java cfcee8c 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java 77b2c37 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillStatement.java fec126e 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillStatementRegistry.java cc797fa 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/Driver.java 974e786 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/InvalidCursorStateSqlException.java PRE-CREATION

>   exec/jdbc/src/main/java/org/apache/drill/jdbc/JdbcApiSqlException.java PRE-CREATION

>   exec/jdbc/src/test/java/org/apache/drill/jdbc/DrillResultSetTest.java PRE-CREATION

>   exec/jdbc/src/test/java/org/apache/drill/jdbc/DriverTest.java PRE-CREATION 
>   exec/jdbc/src/test/java/org/apache/drill/jdbc/JdbcTest.java 40b1445 
>   exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Bug1735ConnectionCloseTest.java
PRE-CREATION 
>   exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Bug1735ResultSetCloseReleasesBuffersTest.java
PRE-CREATION 
>   exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestJdbcDistQuery.java b2f86ea 
>   exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestJdbcQuery.java 682fca3 
>   exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestMetadataDDL.java 93925fe 
>   exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestViews.java 0f9e25e 
> 
> Diff: https://reviews.apache.org/r/28686/diff/
> 
> 
> Testing
> -------
> 
> PENDING (earlier version was working; resolving current problems)
> 
> 
> Thanks,
> 
> Daniel Barclay
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message