drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sudheesh Katkam" <skat...@maprtech.com>
Subject Re: Review Request 31938: DRILL-2275: Need implementations of sys tables for drill memory and threads profiles
Date Fri, 20 Mar 2015 01:32:46 GMT


> On March 20, 2015, 1:28 a.m., Chris Westin wrote:
> > exec/java-exec/src/test/java/org/apache/drill/exec/store/sys/TestSystemTable.java,
line 48
> > <https://reviews.apache.org/r/31938/diff/5-6/?file=900471#file900471line48>
> >
> >     Shouldn't this be a TODO? Of course, inquiring minds what to know "enhance it
how?" If you're going to put in a comment like this (which I think is great), you need to
be more specific.

This is actually meant for me. I should've mentioned my name.


- Sudheesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31938/#review77148
-----------------------------------------------------------


On March 20, 2015, 12:02 a.m., Sudheesh Katkam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31938/
> -----------------------------------------------------------
> 
> (Updated March 20, 2015, 12:02 a.m.)
> 
> 
> Review request for drill and Venki Korukanti.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> DRILL-2275: Added support to allow for querying cluster state information.
> + If table isDistributed(), BatchCreator and SystemTableScan allow for a distributed
query.
> + SystemRecordReader reads SystemRecords.
> + There is now a generic data type for static tables.
> + GroupScan can enforce width to be maximum width on ExcessiveExchangeRemover.
> + GroupScan has minimum width for SimpleParallelizer.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/drill/common/JSONOptions.java 64e6d52 
>   exec/java-exec/src/main/java/org/apache/drill/exec/memory/TopLevelAllocator.java af8c1dc

>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractGroupScan.java
276ecb5 
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/GroupScan.java 23860a3

>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/ParallelizationInfo.java
75a009e 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/SimpleParallelizer.java
12043ce 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/Stats.java e61b38f

>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/StatsCollector.java
1f56556 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/ExcessiveExchangeIdentifier.java
a237014 
>   exec/java-exec/src/main/java/org/apache/drill/exec/store/RecordDataType.java PRE-CREATION

>   exec/java-exec/src/main/java/org/apache/drill/exec/store/pojo/PojoDataType.java c1e64e6

>   exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/DrillbitIterator.java
67d7cf9 
>   exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/MemoryRecord.java PRE-CREATION

>   exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/StaticDrillTable.java
c1e8dd1 
>   exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/SystemRecord.java PRE-CREATION

>   exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/SystemRecordReader.java
PRE-CREATION 
>   exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/SystemTable.java 0bf2156

>   exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/SystemTableBatchCreator.java
a1bec1e 
>   exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/SystemTablePlugin.java
2c70fd4 
>   exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/SystemTablePluginConfig.java
93fe68e 
>   exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/SystemTableScan.java cdd0d18

>   exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/ThreadsRecord.java PRE-CREATION

>   exec/java-exec/src/test/java/org/apache/drill/exec/store/sys/TestSystemTable.java c1803bc

> 
> Diff: https://reviews.apache.org/r/31938/diff/
> 
> 
> Testing
> -------
> 
> Tested on 3-node cluster and in embedded mode.
> ```
> > select * from sys.memory;
> +------------+------------+--------------+------------+----------------+------------+
> |  hostname  | user_port  | heap_current |  heap_max  | direct_current | direct_max |
> +------------+------------+--------------+------------+----------------+------------+
> | perfnode206.perf.lab | 31010      | 375599272    | 4225236992 | 6048576        | 8589934592
|
> | perfnode207.perf.lab | 31010      | 275524512    | 4225236992 | 2000000        | 8589934592
|
> | perfnode208.perf.lab | 31010      | 289288416    | 4225236992 | 2000000        | 8589934592
|
> +------------+------------+--------------+------------+----------------+------------+
> ```
> 
> 
> Thanks,
> 
> Sudheesh Katkam
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message