drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sudheesh Katkam" <skat...@maprtech.com>
Subject Re: Review Request 31938: DRILL-2275: Need implementations of sys tables for drill memory and threads profiles
Date Thu, 19 Mar 2015 20:48:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31938/
-----------------------------------------------------------

(Updated March 19, 2015, 8:48 p.m.)


Review request for drill and Venki Korukanti.


Changes
-------

Renamed columns.
Get heap max memory and not init memory (+ refactoring)


Repository: drill-git


Description
-------

DRILL-2275: Added support to allow for querying cluster state information.
+ If table isDistributed(), BatchCreator and SystemTableScan allow for a distributed query.
+ SystemRecordReader reads SystemRecords.
+ There is now a generic data type for static tables.
+ GroupScan can enforce width to be maximum width on ExcessiveExchangeRemover.
+ GroupScan has minimum width for SimpleParallelizer.


Diffs (updated)
-----

  common/src/main/java/org/apache/drill/common/JSONOptions.java 64e6d52 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractGroupScan.java
276ecb5 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/GroupScan.java 23860a3

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/ParallelizationInfo.java
75a009e 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/SimpleParallelizer.java
f8d1803 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/Stats.java e61b38f 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/StatsCollector.java
1f56556 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/ExcessiveExchangeIdentifier.java
a237014 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/RecordDataType.java PRE-CREATION

  exec/java-exec/src/main/java/org/apache/drill/exec/store/pojo/PojoDataType.java c1e64e6

  exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/DrillbitIterator.java 67d7cf9

  exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/MemoryRecord.java PRE-CREATION

  exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/StaticDrillTable.java c1e8dd1

  exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/SystemRecord.java PRE-CREATION

  exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/SystemRecordReader.java PRE-CREATION

  exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/SystemTable.java 0bf2156 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/SystemTableBatchCreator.java
a1bec1e 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/SystemTablePlugin.java 2c70fd4

  exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/SystemTablePluginConfig.java
93fe68e 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/SystemTableScan.java cdd0d18

  exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/ThreadsRecord.java PRE-CREATION

  exec/java-exec/src/test/java/org/apache/drill/exec/store/sys/TestSystemTable.java c1803bc


Diff: https://reviews.apache.org/r/31938/diff/


Testing (updated)
-------

Tested on 3-node cluster and in embedded mode.
```
> select * from sys.memory;
+------------+------------+-----------------+-------------------+---------------------+
| host_name  | user_port  | total_heap_size | current_heap_size | direct_alloc_memory |
+------------+------------+-----------------+-------------------+---------------------+
| perfnode208.perf.lab | 31010      | 4225236992      | 483863736         | 5000147      
      |
| perfnode207.perf.lab | 31010      | 4225236992      | 341408256         | 2000000      
      |
| perfnode206.perf.lab | 31010      | 4225236992      | 311670104         | 2000000      
      |
+------------+------------+-----------------+-------------------+---------------------+
```


Thanks,

Sudheesh Katkam


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message