drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hanifi Gunes" <hanifigu...@gmail.com>
Subject Re: Review Request 32223: DRILL-2193: implement fast count / skip-all semantics for JSON reader
Date Thu, 19 Mar 2015 17:49:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32223/
-----------------------------------------------------------

(Updated March 19, 2015, 5:49 p.m.)


Review request for drill, Aman Sinha and Parth Chandra.


Changes
-------

Addressed Aman's comments.


Bugs: DRILL-2193
    https://issues.apache.org/jira/browse/DRILL-2193


Repository: drill-git


Description
-------

DRILL-2193: implement fast count / skip-all semantics for JSON reader

This patch introduces an abstraction for JSON processing and implements a efficient counting
JSON reader if query is in skip-all mode(see DRILL-2358).


Diffs (updated)
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONRecordReader.java
c343177a719b5f36f51bcb2f84d68518ba1ae02f 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JsonProcessor.java PRE-CREATION

  exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/reader/BaseJsonProcessor.java
PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/reader/CountingJsonReader.java
PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java cc5c8af63c6383eb8d2e28a409a3c055bf5cc737


Diff: https://reviews.apache.org/r/32223/diff/


Testing
-------

unit + regression


Thanks,

Hanifi Gunes


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message