drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Parth Chandra" <pchan...@maprtech.com>
Subject Re: Review Request 31876: DRILL-2415: Export Drill C++ Client symbols so as to provide dynamic linking
Date Thu, 19 Mar 2015 16:59:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31876/#review77061
-----------------------------------------------------------

Ship it!


Ship It!

- Parth Chandra


On March 19, 2015, 3:16 a.m., Alexander zarei wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31876/
> -----------------------------------------------------------
> 
> (Updated March 19, 2015, 3:16 a.m.)
> 
> 
> Review request for drill, Norris Lee, Parth Chandra, and Xiao Meng.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> DRILL-2415: Export Drill C++ Client symbols so as to provide dynamic linking
> 
> 
> Diffs
> -----
> 
>   contrib/native/client/src/clientlib/drillClient.cpp 878dad4 
>   contrib/native/client/src/include/drill/drillClient.hpp 19fec69 
>   contrib/native/client/src/include/drill/recordBatch.hpp 4abc2de 
> 
> Diff: https://reviews.apache.org/r/31876/diff/
> 
> 
> Testing
> -------
> 
> Built and tested on Windows Win32/x64, Linux x86/x8664 and Mac OS X Darwin Universal
platforms;
> 
> Tested by query submitter with
> 
> ./querySubmitter query='SELECT * FROM `hive43`.`default`.`orders` limit 5000;SELEct *
from INFORMATION_SCHEMA.SCHEMATA' type=sql connectStr=local=192.168.39.44:31010 api=async
logLevel=fatal > test.txt
> 
> (please note that for Windows double quotations needed e.g. "select * ...")
> 
> and comparing the result files with the previous version of C++ client;
> 
> Also thoroughly tested by automated and manual testing of Drill ODBC driver.
> 
> Thanks,
> Alex
> 
> 
> Thanks,
> 
> Alexander zarei
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message