drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mehant Baid" <baid.meh...@gmail.com>
Subject Re: Review Request 32082: DRILL-2136: Fixed isNull for Nullable... SqlAccessors.
Date Tue, 17 Mar 2015 20:27:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32082/#review76793
-----------------------------------------------------------

Ship it!


Ship It!

- Mehant Baid


On March 15, 2015, 9:11 p.m., Daniel Barclay wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32082/
> -----------------------------------------------------------
> 
> (Updated March 15, 2015, 9:11 p.m.)
> 
> 
> Review request for drill, Mehant Baid and Parth Chandra.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Fixed generated isNull methods which always returned false, even for Nullable... versions
of SqlAccessor.
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/codegen/templates/SqlAccessors.java b569185 
> 
> Diff: https://reviews.apache.org/r/32082/diff/
> 
> 
> Testing
> -------
> 
> Ran new tests for JDBC metadata fixes (DRILL-2420--related) and existing tests.
> 
> 
> Thanks,
> 
> Daniel Barclay
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message