drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Hsuan-Yi Chu" <hsua...@usc.edu>
Subject Re: Review Request 32089: DRILL-2311: Create table with same columns of different case results in a java.lang.IllegalStateException
Date Tue, 17 Mar 2015 17:40:44 GMT


> On March 17, 2015, 4:34 a.m., Aman Sinha wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java,
line 369
> > <https://reviews.apache.org/r/32089/diff/3/?file=897157#file897157line369>
> >
> >     comment looks good..but could you move it below the else statement ... that's
the general convention.

Done!!! Please see the updated diff.
Will upload one to Jira after this review passes through.


- Sean Hsuan-Yi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32089/#review76709
-----------------------------------------------------------


On March 17, 2015, 1:57 a.m., Sean Hsuan-Yi Chu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32089/
> -----------------------------------------------------------
> 
> (Updated March 17, 2015, 1:57 a.m.)
> 
> 
> Review request for drill and Aman Sinha.
> 
> 
> Bugs: DRILL-2311
>     https://issues.apache.org/jira/browse/DRILL-2311
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> In ProjectRecordBatch, ensure the output columns are unique.
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
8f7812f 
>   exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java 8ae0ae4 
> 
> Diff: https://reviews.apache.org/r/32089/diff/
> 
> 
> Testing
> -------
> 
> Unit tests, all QA tests
> 
> 
> Thanks,
> 
> Sean Hsuan-Yi Chu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message