drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aman Sinha" <asi...@maprtech.com>
Subject Re: Review Request 32089: DRILL-2311: Create table with same columns of different case results in a java.lang.IllegalStateException
Date Mon, 16 Mar 2015 21:54:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32089/#review76653
-----------------------------------------------------------

Ship it!


Couple of minor comments below.


exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
<https://reviews.apache.org/r/32089/#comment124253>

    Can you add some comments here to indicate which columns would be considered here and
about uniquely naming the columns.



exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java
<https://reviews.apache.org/r/32089/#comment124259>

    maybe shorten the name :)


- Aman Sinha


On March 16, 2015, 7:45 p.m., Sean Hsuan-Yi Chu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32089/
> -----------------------------------------------------------
> 
> (Updated March 16, 2015, 7:45 p.m.)
> 
> 
> Review request for drill and Aman Sinha.
> 
> 
> Bugs: DRILL-2311
>     https://issues.apache.org/jira/browse/DRILL-2311
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> In ProjectRecordBatch, ensure the output columns are unique.
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
8f7812f 
>   exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java 8ae0ae4 
> 
> Diff: https://reviews.apache.org/r/32089/diff/
> 
> 
> Testing
> -------
> 
> Unit tests, all QA tests
> 
> 
> Thanks,
> 
> Sean Hsuan-Yi Chu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message