drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Altekruse" <altekruseja...@gmail.com>
Subject Review Request 32116: DRILL-2219 - concurrent modification exception risk in TopLevelAllocator
Date Mon, 16 Mar 2015 17:50:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32116/
-----------------------------------------------------------

Review request for drill and Chris Westin.


Bugs: DRILL-2219
    https://issues.apache.org/jira/browse/DRILL-2219


Repository: drill-git


Description
-------

We iterate over a list of child allocators in the close method, when close is being called
we are not guarenteed to be free of fragments that can still request a new child allocator
and modify the list (in this case a map because it stores a stack trace list with it).


Diffs
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/memory/TopLevelAllocator.java 67e1fdb


Diff: https://reviews.apache.org/r/32116/diff/


Testing
-------

Re-running tests on the patch rebased on master, will post results soon.


Thanks,

Jason Altekruse


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message