drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Altekruse" <altekruseja...@gmail.com>
Subject Re: Review Request 31567: 2406 - part 1 - (previously 2060) refactor interpreted expression evaluation
Date Mon, 16 Mar 2015 17:10:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31567/
-----------------------------------------------------------

(Updated March 16, 2015, 5:10 p.m.)


Review request for drill, Aman Sinha, Jacques Nadeau, Jinfeng Ni, and Mehant Baid.


Changes
-------

Small changes based on revision to earlier commit ( see https://reviews.apache.org/r/30754/diff/3-4/
for more details)


Bugs: DRILL-2060 and DRILL-2406
    https://issues.apache.org/jira/browse/DRILL-2060
    https://issues.apache.org/jira/browse/DRILL-2406


Repository: drill-git


Description
-------

The interpreter was previously not used in normal execution, it was added with unit tests
but never hooked up to an execution component. When trying to use it in the new constant folding
issues I ran into build issues that are described in detail on the 2060 JIRA.

I have created this to isolate the changes from the others in 2060.


Diffs (updated)
-----

  exec/interpreter/pom.xml 20539a8 
  exec/interpreter/src/test/java/org/apache/drill/exec/expr/ExpressionInterpreterTest.java
a94ef94 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/DrillFuncHolderExpr.java bc631b8

  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillBooleanOPHolder.java 743598a

  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillDecimalAddFuncHolder.java
3871cd7 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillDecimalCastFuncHolder.java
db49173 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillDecimalDivScaleFuncHolder.java
683a04f 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillDecimalMaxScaleFuncHolder.java
aa8e2b5 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillDecimalModScaleFuncHolder.java
b5e754e 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillDecimalSetScaleFuncHolder.java
47b8507 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillDecimalSumScaleFuncHolder.java
cb8bfed 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillDecimalZeroScaleFuncHolder.java
674fc87 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillSimpleFuncHolder.java ec284a7

  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionConverter.java 0127e6e

  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/interpreter/DrillFuncInterpreter.java
3a83542 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/interpreter/DrillSimpleFuncInterpreter.java
e3696f0 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/interpreter/InterpreterBuilder.java
3dac818 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/interpreter/InterpreterEvaluator.java
0fe36cb 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/interpreter/InterpreterGenerator.java
6cede33 
  exec/java-exec/src/main/java/org/apache/drill/exec/vector/ValueHolderHelper.java 2f5bf6a

  exec/java-exec/src/test/java/org/apache/drill/exec/fn/interp/ExpressionInterpreterTest.java
PRE-CREATION 
  exec/java-exec/src/test/resources/functions/interp/test_input.csv PRE-CREATION 
  exec/pom.xml e27e50b 

Diff: https://reviews.apache.org/r/31567/diff/


Testing
-------

Cluster tests are passing, waiting on unit tests.


Thanks,

Jason Altekruse


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message