drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Barclay" <dbarc...@maprtech.com>
Subject Review Request 31995: DRILL-2128 fix for DatabaseMetaData.getColumns's DATA_TYPE and TYPE_NAME (pt. 2--core fix)
Date Thu, 12 Mar 2015 20:58:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31995/
-----------------------------------------------------------

Review request for drill and Parth Chandra.


Repository: drill-git


Description
-------

- Created basic test for DATA_TYPE and TYPE_NAME.
- Fixed DATA_TYPE:  Added mapping from type name/descriptor strings from
  INFORMATION_SCHEMA.COLUMNS.DATA_TYPE to java.sql.Types.* integer type codes
  for DatabaseMetaData.getColumns's DATA_TYPE.
- Fixed TYPE_NAME:  Added TYPE_NAME returning type name/descriptor strings
  from INFORMATION_SCHEMA.COLUMNS.DATA_TYPE
- Added FIXMEs for some missing/misnamed/wrong fields.  (See DRILL-2420.)

NOTE:  There are a number of unknowns noted in TODO comments.


Diffs
-----

  exec/jdbc/src/main/java/org/apache/drill/jdbc/MetaImpl.java 127751d 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2128GetColumnsBugsTest.java PRE-CREATION


Diff: https://reviews.apache.org/r/31995/diff/


Testing
-------

Ran new and existing tests.


Thanks,

Daniel Barclay


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message