drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Parth Chandra" <pchan...@maprtech.com>
Subject Re: Review Request 31953: DRILL-2128: Pt. 1: Preparatory changes before core changes for actual fix.
Date Thu, 12 Mar 2015 04:05:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31953/#review76204
-----------------------------------------------------------

Ship it!


Ship It!

- Parth Chandra


On March 11, 2015, 10:09 p.m., Daniel Barclay wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31953/
> -----------------------------------------------------------
> 
> (Updated March 11, 2015, 10:09 p.m.)
> 
> 
> Review request for drill and Parth Jagirdar.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Added comments showing getColumns() column number and missing/misnamed columns.
> Aligned SQL (Java strings and net SQL).
> 
> 
> Diffs
> -----
> 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/MetaImpl.java 0ea8d5c 
> 
> Diff: https://reviews.apache.org/r/31953/diff/
> 
> 
> Testing
> -------
> 
> Ran tests.
> 
> 
> Thanks,
> 
> Daniel Barclay
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message