drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Altekruse" <altekruseja...@gmail.com>
Subject Re: Review Request 30636: DRILL-2143 - part 1 - remove record batch interface from UDF interface
Date Thu, 05 Mar 2015 00:22:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30636/
-----------------------------------------------------------

(Updated March 5, 2015, 12:21 a.m.)


Review request for drill, Jacques Nadeau, Jinfeng Ni, and Mehant Baid.


Changes
-------

Update one date function based on recent change


Bugs: DRILL-2143
    https://issues.apache.org/jira/browse/DRILL-2143


Repository: drill-git


Description
-------

Remove incoming record batch from setup method of DrillFuncs. Date functions that need the
incoming batch have been disbled here, see the other reviewboard link posted on the JIRA for
this issue. This patch only has the find/replace in freemarker templates and intellij refactorings
of the non-build-time-generated functions. The next patch adds an injectable type to bring
back the date functions and make the interpreted expression evaluation work with the new interface.


Diffs (updated)
-----

  exec/java-exec/src/main/codegen/templates/AggrBitwiseLogicalTypeFunctions.java e659d32 
  exec/java-exec/src/main/codegen/templates/AggrTypeFunctions1.java e4386b2 
  exec/java-exec/src/main/codegen/templates/AggrTypeFunctions2.java fda1457 
  exec/java-exec/src/main/codegen/templates/AggrTypeFunctions3.java acf877a 
  exec/java-exec/src/main/codegen/templates/CastDateDate.java b849c76 
  exec/java-exec/src/main/codegen/templates/CastDateVarChar.java c261e29 
  exec/java-exec/src/main/codegen/templates/CastFunctions.java 41c1557 
  exec/java-exec/src/main/codegen/templates/CastFunctionsSrcVarLen.java 57740c9 
  exec/java-exec/src/main/codegen/templates/CastFunctionsSrcVarLenTargetVarLen.java cd8f7bd

  exec/java-exec/src/main/codegen/templates/CastFunctionsTargetVarLen.java 455ab13 
  exec/java-exec/src/main/codegen/templates/CastHigh.java 934b60b 
  exec/java-exec/src/main/codegen/templates/CastIntervalInterval.java e85b724 
  exec/java-exec/src/main/codegen/templates/CastIntervalVarChar.java 829fe47 
  exec/java-exec/src/main/codegen/templates/CastVarCharDate.java 41c7855 
  exec/java-exec/src/main/codegen/templates/CastVarCharInterval.java eaebf02 
  exec/java-exec/src/main/codegen/templates/CastVarCharToNullableNumeric.java e417f26 
  exec/java-exec/src/main/codegen/templates/ComparisonFunctions.java 011d4d9 
  exec/java-exec/src/main/codegen/templates/ConvertToNullableHolder.java 57efd5e 
  exec/java-exec/src/main/codegen/templates/CorrelationTypeFunctions.java 19f9c59 
  exec/java-exec/src/main/codegen/templates/CovarTypeFunctions.java b8131c2 
  exec/java-exec/src/main/codegen/templates/DateIntervalAggrFunctions1.java 1c9b76f 
  exec/java-exec/src/main/codegen/templates/DateIntervalFunctionTemplates/DateDateArithmeticFunctions.java
6c03f3b 
  exec/java-exec/src/main/codegen/templates/DateIntervalFunctionTemplates/DateIntervalArithmeticFunctions.java
0b0da52 
  exec/java-exec/src/main/codegen/templates/DateIntervalFunctionTemplates/DateToCharFunctions.java
695cfcf 
  exec/java-exec/src/main/codegen/templates/DateIntervalFunctionTemplates/DateTruncFunctions.java
b9cd0c8 
  exec/java-exec/src/main/codegen/templates/DateIntervalFunctionTemplates/Extract.java 0858c3f

  exec/java-exec/src/main/codegen/templates/DateIntervalFunctionTemplates/IntervalIntervalArithmetic.java
484c8f4 
  exec/java-exec/src/main/codegen/templates/DateIntervalFunctionTemplates/IntervalNumericArithmetic.java
ce73f74 
  exec/java-exec/src/main/codegen/templates/DateIntervalFunctionTemplates/ToDateTypeFunctions.java
fffaef4 
  exec/java-exec/src/main/codegen/templates/DateIntervalFunctionTemplates/ToTimeStampFunction.java
4fd619f 
  exec/java-exec/src/main/codegen/templates/Decimal/CastDecimalDenseDecimalSparse.java cb0dc58

  exec/java-exec/src/main/codegen/templates/Decimal/CastDecimalFloat.java 4d8d1a5 
  exec/java-exec/src/main/codegen/templates/Decimal/CastDecimalInt.java c435f6d 
  exec/java-exec/src/main/codegen/templates/Decimal/CastDecimalSimilar.java cd2c390 
  exec/java-exec/src/main/codegen/templates/Decimal/CastDecimalSparseDecimalDense.java 0f8790f

  exec/java-exec/src/main/codegen/templates/Decimal/CastDecimalVarchar.java ed62444 
  exec/java-exec/src/main/codegen/templates/Decimal/CastDownwardDecimal.java bd86819 
  exec/java-exec/src/main/codegen/templates/Decimal/CastFloatDecimal.java c05b2e5 
  exec/java-exec/src/main/codegen/templates/Decimal/CastIntDecimal.java 139fff8 
  exec/java-exec/src/main/codegen/templates/Decimal/CastSrcDecimalSimple.java 7750c62 
  exec/java-exec/src/main/codegen/templates/Decimal/CastVarCharDecimal.java 84be392 
  exec/java-exec/src/main/codegen/templates/Decimal/DecimalAggrTypeFunctions1.java 54cec10

  exec/java-exec/src/main/codegen/templates/Decimal/DecimalAggrTypeFunctions2.java 7277e19

  exec/java-exec/src/main/codegen/templates/Decimal/DecimalFunctions.java b9029cd 
  exec/java-exec/src/main/codegen/templates/IntervalAggrFunctions2.java c7f5918 
  exec/java-exec/src/main/codegen/templates/MathFunctionTemplates.java 9ec2178 
  exec/java-exec/src/main/codegen/templates/MathFunctions.java fa5f1ac 
  exec/java-exec/src/main/codegen/templates/NullOperator.java 73eda1a 
  exec/java-exec/src/main/codegen/templates/NumericFunctionsTemplates.java 65ac923 
  exec/java-exec/src/main/codegen/templates/NumericToCharFunctions.java ff2c675 
  exec/java-exec/src/main/codegen/templates/SumZeroAggr.java 5b0c4a0 
  exec/java-exec/src/main/codegen/templates/VarCharAggrFunctions1.java 01b5565 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/DrillAggFunc.java b29410d 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/DrillSimpleFunc.java 8821c63 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/AggregateErrorFunctions.java
48a6625 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/Alternator.java 9350429

  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/BitFunctions.java ae42872

  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/BooleanAggrFunctions.java
d555fad 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/ByteSubstring.java 8831d98

  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CastBigIntDate.java 9c0703e

  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CastBigIntTimeStamp.java
ea92f3c 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CastBigIntTimeStampTZ.java
014a4d4 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CastIntTime.java f4a4ed0

  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CastVarCharVar16Char.java
5280717 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CharSubstring.java 62e9d70

  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/DateTypeFunctions.java cc4be89

  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/HashFunctions.java 9658fdb

  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/IsFalse.java 12a2205 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/IsNotFalse.java 5b8a9bd

  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/IsNotTrue.java 1485e8c 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/IsTrue.java 2fd65e3 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/Mappify.java da9009c 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MathFunctions.java 39288b4

  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/Not.java db33247 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SimpleCastFunctions.java
8a09cff 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SimpleRepeatedFunctions.java
f7f0e91 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StringFunctions.java a3bc1de

  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/BigIntBEConvertFrom.java
dc0f6b7 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/BigIntBEConvertTo.java
e645f4b 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/BigIntConvertFrom.java
2f303c4 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/BigIntConvertTo.java
57dd2d5 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/BigIntVLongConvertFrom.java
f398071 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/BigIntVLongConvertTo.java
c647d3a 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/BooleanByteConvertFrom.java
d03c951 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/BooleanByteConvertTo.java
43db659 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DateEpochBEConvertFrom.java
c511935 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DateEpochBEConvertTo.java
12136f3 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DateEpochConvertFrom.java
fa1c063 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DateEpochConvertTo.java
bddb621 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DoubleBEConvertFrom.java
011c7a6 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DoubleBEConvertTo.java
948f8b0 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DoubleConvertFrom.java
1fa9166 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DoubleConvertTo.java
29f625e 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DummyConvertFrom.java
50e0cbb 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DummyConvertTo.java
c2ac3ef 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DummyFlatten.java d4e3115

  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/FloatBEConvertFrom.java
095588c 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/FloatBEConvertTo.java
4b6d51d 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/FloatConvertFrom.java
4ed553b 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/FloatConvertTo.java
3cce965 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/IntBEConvertFrom.java
969adde 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/IntBEConvertTo.java
02ee8e2 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/IntConvertFrom.java
9948e7a 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/IntConvertTo.java 4dd1ef4

  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/IntVIntConvertFrom.java
0cf729f 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/IntVIntConvertTo.java
715c72d 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/JsonConvertFrom.java
eb788f3 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/JsonConvertTo.java
7f7d6f2 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/SmallIntBEConvertFrom.java
1f22575 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/SmallIntBEConvertTo.java
b1620e6 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/SmallIntConvertFrom.java
463ec35 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/SmallIntConvertTo.java
2cdaafb 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/TimeEpochBEConvertFrom.java
7aee12d 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/TimeEpochBEConvertTo.java
bbd75a6 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/TimeEpochConvertFrom.java
9fb272b 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/TimeEpochConvertTo.java
c9baad3 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/TinyIntConvertFrom.java
4380c13 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/TinyIntConvertTo.java
3abde4f 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/UInt8ConvertFrom.java
dab73a7 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/UInt8ConvertTo.java
904151f 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/UTF16ConvertFrom.java
82562c8 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/UTF16ConvertTo.java
cff1851 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/UTF8ConvertFrom.java
a6f8901 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/UTF8ConvertTo.java
093d6b9 
  exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/GeneratorFunctions.java a9c244a


Diff: https://reviews.apache.org/r/30636/diff/


Testing
-------

This is an early patch, I have run a number of relevant unit tests but not the entire suite.


Thanks,

Jason Altekruse


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message