drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hanifi Gunes" <hgu...@maprtech.com>
Subject Re: Review Request 31647: DRILL-2358: Ensure DrillScanRel differentiates skip-all, scan-all & scan-some in a backward compatible fashion
Date Tue, 03 Mar 2015 02:47:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31647/
-----------------------------------------------------------

(Updated March 3, 2015, 2:47 a.m.)


Review request for drill, Aman Sinha and Jinfeng Ni.


Changes
-------

Adressed changes
- impl equals, hashCode
- rename scan modes


Bugs: DRILL-2358
    https://issues.apache.org/jira/browse/DRILL-2358


Repository: drill-git


Description
-------

DRILL-2358: Ensure DrillScanRel differentiates skip-all, scan-all & scan-some in a backward
compatible fashion

this is an intermediary change whose functionality will be plugged in by individual storage
plugins. Thus, this patch should not affect the overall stability.


Diffs (updated)
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/ColumnList.java PRE-CREATION

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillScanRel.java 45e10585f9c5bc303551d342c2602f12026dda17

  exec/java-exec/src/main/java/org/apache/drill/exec/store/AbstractRecordReader.java 554b3e77c53039edeeadd7223ab0cec8f0e2c199


Diff: https://reviews.apache.org/r/31647/diff/


Testing
-------

unit tests.


Thanks,

Hanifi Gunes


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message