Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3A87B10BE6 for ; Sat, 21 Feb 2015 01:46:46 +0000 (UTC) Received: (qmail 34335 invoked by uid 500); 21 Feb 2015 01:46:46 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 34269 invoked by uid 500); 21 Feb 2015 01:46:46 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 34255 invoked by uid 500); 21 Feb 2015 01:46:45 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 34247 invoked by uid 99); 21 Feb 2015 01:46:45 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 21 Feb 2015 01:46:45 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 107B61D2395; Sat, 21 Feb 2015 01:46:44 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7003616845364690297==" MIME-Version: 1.0 Subject: Re: Review Request 30965: Follow up on DRILL-133 (LocalExchange) to save CPU cycles on hash generation when using in HashToLocalExchange From: "Yuliya Feldman" To: "Venki Korukanti" , "Jacques Nadeau" , "Steven Phillips" Cc: "Yuliya Feldman" , "Chris Westin" , "drill" Date: Sat, 21 Feb 2015 01:46:44 -0000 Message-ID: <20150221014644.21353.81367@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Yuliya Feldman" X-ReviewGroup: drill-git X-ReviewRequest-URL: https://reviews.apache.org/r/30965/ X-Sender: "Yuliya Feldman" References: <20150213052913.29076.75602@reviews.apache.org> In-Reply-To: <20150213052913.29076.75602@reviews.apache.org> Reply-To: "Yuliya Feldman" X-ReviewRequest-Repository: drill-git --===============7003616845364690297== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30965/ ----------------------------------------------------------- (Updated Feb. 20, 2015, 5:46 p.m.) Review request for drill, Jacques Nadeau, Steven Phillips, and Venki Korukanti. Changes ------- Updated based of first code review round Bugs: DRILL-2209 https://issues.apache.org/jira/browse/DRILL-2209 Repository: drill-git Description ------- Insert Project operator to add new column "EXPRHASH" with hash expression for fields that are used for HashToRandomExchange Remove Project operator after HashRandomExchange (or Demux) since it will create problems to fields ordering in HashJoin. Tight this to MuxExchange - so if MuxExchange is enabled, Project is inserted. Diffs (updated) ----- exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/HashToRandomExchangePrel.java 372c75d exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/InsertLocalExchangeVisitor.java PRE-CREATION Diff: https://reviews.apache.org/r/30965/diff/ Testing ------- Need to add Unit Tests. tested live, run Functional and TPCH tests Thanks, Yuliya Feldman --===============7003616845364690297==--