Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 84CE11768D for ; Wed, 4 Feb 2015 19:51:30 +0000 (UTC) Received: (qmail 82444 invoked by uid 500); 4 Feb 2015 19:51:31 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 82384 invoked by uid 500); 4 Feb 2015 19:51:31 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 82372 invoked by uid 500); 4 Feb 2015 19:51:30 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 82365 invoked by uid 99); 4 Feb 2015 19:51:30 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Feb 2015 19:51:30 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C806F1CC191; Wed, 4 Feb 2015 19:51:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3503647390945520981==" MIME-Version: 1.0 Subject: Re: Review Request 30593: DRILL-2151: VariableLengthVector.copyFromSafe() unnecessary sets the offsetVector From: "Chris Westin" To: "Chris Westin" , "abdelhakim deneche" , "drill" Date: Wed, 04 Feb 2015 19:51:26 -0000 Message-ID: <20150204195126.1285.32196@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Chris Westin" X-ReviewGroup: drill-git X-ReviewRequest-URL: https://reviews.apache.org/r/30593/ X-Sender: "Chris Westin" References: <20150204195056.1286.54625@reviews.apache.org> In-Reply-To: <20150204195056.1286.54625@reviews.apache.org> Reply-To: "Chris Westin" X-ReviewRequest-Repository: drill-git --===============3503647390945520981== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Feb. 4, 2015, 11:50 a.m., Chris Westin wrote: > > Ship It! Not that my vote counts yet.... - Chris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30593/#review71025 ----------------------------------------------------------- On Feb. 4, 2015, 8:42 a.m., abdelhakim deneche wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30593/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2015, 8:42 a.m.) > > > Review request for drill. > > > Bugs: DRILL-2151 > https://issues.apache.org/jira/browse/DRILL-2151 > > > Repository: drill-git > > > Description > ------- > > emoved the line > > offsetVector.getMutator().setSafe( (thisIndex+1) * ${type.width}, outputStart + len); > > from *VariableLengthVector.copyFromSafe()* > > and refactored the call to *from.offsetVector.getAccessor()* to reuse the result. > > > Diffs > ----- > > exec/java-exec/src/main/codegen/templates/VariableLengthVectors.java aa5b702 > > Diff: https://reviews.apache.org/r/30593/diff/ > > > Testing > ------- > > all unit tests pass > "Functional - Passing - new" passes on 171 > "Advanced TPCH SF100" passes on 57 > the query described in DRILL-2151 runs fine now > > > Thanks, > > abdelhakim deneche > > --===============3503647390945520981==--