Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7E4A6173C3 for ; Tue, 3 Feb 2015 23:35:15 +0000 (UTC) Received: (qmail 10863 invoked by uid 500); 3 Feb 2015 23:35:16 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 10811 invoked by uid 500); 3 Feb 2015 23:35:16 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 10794 invoked by uid 500); 3 Feb 2015 23:35:15 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 10789 invoked by uid 99); 3 Feb 2015 23:35:15 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Feb 2015 23:35:15 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6959A1CC3D4; Tue, 3 Feb 2015 23:35:19 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8929912295674535831==" MIME-Version: 1.0 Subject: Review Request 30593: VariableLengthVector.copyFromSafe() unnecessary sets the offsetVector From: "abdelhakim deneche" To: "abdelhakim deneche" , "drill" Date: Tue, 03 Feb 2015 23:35:19 -0000 Message-ID: <20150203233519.30544.65279@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "abdelhakim deneche" X-ReviewGroup: drill-git X-ReviewRequest-URL: https://reviews.apache.org/r/30593/ X-Sender: "abdelhakim deneche" Reply-To: "abdelhakim deneche" X-ReviewRequest-Repository: drill-git --===============8929912295674535831== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30593/ ----------------------------------------------------------- Review request for drill. Bugs: DRILL-2151 https://issues.apache.org/jira/browse/DRILL-2151 Repository: drill-git Description ------- emoved the line offsetVector.getMutator().setSafe( (thisIndex+1) * ${type.width}, outputStart + len); from *VariableLengthVector.copyFromSafe()* and refactored the call to *from.offsetVector.getAccessor()* to reuse the result. Diffs ----- exec/java-exec/src/main/codegen/templates/VariableLengthVectors.java aa5b702 Diff: https://reviews.apache.org/r/30593/diff/ Testing ------- all unit tests pass "Functional - Passing - new" passes on 171 the query described in DRILL-2151 runs fine now I'm still waiting for 57 to test "TPCH SF100 Parquet" Thanks, abdelhakim deneche --===============8929912295674535831==--