drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Altekruse" <altekruseja...@gmail.com>
Subject Re: Review Request 30754: DRILL-2143 - part 2 - remove record batch interface from UDF interface
Date Sat, 28 Feb 2015 00:04:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30754/
-----------------------------------------------------------

(Updated Feb. 28, 2015, 12:04 a.m.)


Review request for drill, Aman Sinha, Jacques Nadeau, Jinfeng Ni, Mehant Baid, and Parth Chandra.


Bugs: DRILL-2143
    https://issues.apache.org/jira/browse/DRILL-2143


Repository: drill-git


Description
-------

This patch fixes the breakage of removing the record batch from the setup method in the DrillFunc
interface. It adds an injectable type to bring back the date functions and make the interpreted
expression evaluation work with the new interface.


Diffs (updated)
-----

  exec/interpreter/src/test/java/org/apache/drill/exec/expr/ExpressionInterpreterTest.java
a94ef94 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFuncHolder.java 279c428

  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionConverter.java 0127e6e

  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/DateTypeFunctions.java f902d86

  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/interpreter/DrillSimpleFuncInterpreter.java
e3696f0 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/interpreter/InterpreterEvaluator.java
0fe36cb 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/interpreter/InterpreterGenerator.java
6cede33 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/holders/ValueHolder.java 5c2adc6

  exec/java-exec/src/main/java/org/apache/drill/exec/expr/package-info.java PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java e413921 
  exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryDateTimeInfo.java PRE-CREATION

  exec/java-exec/src/main/java/org/apache/drill/exec/ops/UdfUtilities.java PRE-CREATION 
  exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java c59d0af 

Diff: https://reviews.apache.org/r/30754/diff/


Testing
-------

Relevant unit tests, still need to run full suite


Thanks,

Jason Altekruse


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message